-
-
Notifications
You must be signed in to change notification settings - Fork 7
Open
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Description
Generate commit bins and release bins is currently not working as it should.
In StarMod .github/workflows/pio.yml generates this
Current situation:
- commit bins: StarMod-esp32-${{env.git_branch}}-${{env.git_hash}}.bin generated from .pio/build/esp32dev/firmware.bin
- release bins: nothing generated
Desired situation: for both commit bins and release bins, a bin should be generated for each env in pio.ini following the same syntax as local vscode/pio build file names:
- {$APP}{$VERSION}{$PIOENV}.bin e.g. StarMod_24041415_esp32dev.bin, variables are defined in pio.ini
- see tools/post_build: builds local files in ~/Downloads and GitHub builds in GitHub/ewowi/StarMod/build_output/release
To be done:
- Get inspired by Github/MoonModules/WLED/.github/workflows/wlec-ci.yml (copy-refactor-paste / MVP (Minimum Viable Product))
- don't use build_output/firmware and build_output/map (unless good reason)
- don't use .bin.gz (unless good reason)
- take all the envs per default, no need to implement default_envs (unless good reason)
- use the code to take bin files from build_output/release and upload artifacts and release
- add this to pio.yml
- make changes to post_build.py if needed
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed