Allow a supervisor name to be given to Money.ExchangeRates.Supervisor.stop

Author: kipcole9

CHANGELOG.md

@@ -6,6 +6,10 @@ This is the changelog for Money v5.2.1 released on June 23rd, 2020.  For older c
 
 * Configure the `Money.Application` supervisor via the arguments to `Money.Application.start/2` and configure defaults in `mix.exs`. This permits different restart strategies and names.
 
+* Add `Money.ExchangeRates.Supervisor.default_supervisor/0` to return the name of the default supervisor which is `Money.Supervisor`
+
+* Change `Money.ExchangeRates.Supervisor.stop/0` to become `Money.ExchangeRates.Supervisor.stop/{0, 1}` allowing the supervisor name to be passed in. The default is `Money.ExchangeRates.Supervisor.default_supervisor/0`
+
 ### Bug Fixes
 
 * Add back the name of the Application supervisor, `Money.Supervisor`. Thanks for the report of the regression to @jeroenvisser101. Fixes #117.

lib/money/exchange_rates/exchange_rates_supervisor.ex

@@ -52,9 +52,12 @@ defmodule Money.ExchangeRates.Supervisor do
   @doc """
   Stop the Money.ExchangeRates.Supervisor.
 
-  The Money.ExchangeRates.Supervisor is always started
-  with `ex_money` starts even if the config key
-  `:auto_start_exchange_rates_service` is set to `false`.
+  Unless `ex_money` is configured in `mix.exs` as
+  `rumtime: false`, the Money.ExchangeRates.Supervisor
+  is always started when `ex_money` starts even if the
+  config key `:auto_start_exchange_rates_service` is
+  set to `false`.
+
 
   In some instances an application may require the
   `Money.ExchangeRates.Supervisor` to be started under
@@ -71,8 +74,21 @@ defmodule Money.ExchangeRates.Supervisor do
   from within the callback module" for an eanple of how
   to configure the supervisor in this case.
   """
-  def stop do
-    Supervisor.terminate_child(Money.Supervisor, __MODULE__)
+  def stop(supervisor \\ default_supervisor()) do
+    Supervisor.terminate_child(supervisor, __MODULE__)
+  end
+
+  @doc """
+  Returns the name of the default supervisor
+  which is `Money.Supervisor`
+
+  """
+  def default_supervisor do
+    {_, options} =
+      Application.spec(:ex_money)
+      |> Keyword.get(:mod)
+
+    Keyword.get(options, :name)
   end
 
   @doc false

test/application_test.exs

@@ -5,4 +5,8 @@ defmodule Money.Application.Test do
     {_app, options} = Application.spec(:ex_money) |> Keyword.get(:mod)
     assert options == [strategy: :one_for_one, name: Money.Supervisor]
   end
+
+  test "default supervisor name" do
+    assert Money.ExchangeRates.Supervisor.default_supervisor == Money.Supervisor
+  end
 end