time_based valve: move into valve/ subpackage, fix include paths and control_ dispatch

- git mv valve.py → valve/__init__.py, time_based_valve.{h,cpp} → valve/
- __init__.py: from .. import (parent package), add AUTO_LOAD = ["time_based"]
- time_based_valve.h: fix include path to ../time_based_actuator.h, remove
  redundant setup() override (now handled by TimeBasedActuatorBase::setup()),
  fix control() dispatch to call control_() not control()
- time_based_valve.cpp: remove TimeBasedValve::setup() — setup is owned by base
- Add TestTimeBasedValveInheritance class (3 tests) to test_time_based_actuator.py

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: exciton

esphome/components/time_based/valve.py …/components/time_based/valve/__init__.pyesphome/components/time_based/valve.py renamed to esphome/components/time_based/valve/__init__.py esphome/components/time_based/valve.py renamed to esphome/components/time_based/valve/__init__.py

@@ -2,13 +2,15 @@
 from esphome.components import valve
 import esphome.config_validation as cv
 
-from . import (
+from .. import (
     TIME_BASED_ACTUATOR_SCHEMA,
     TimeBasedActuatorBase,
     apply_time_based_actuator_config,
     time_based_ns,
 )
 
+AUTO_LOAD = ["time_based"]
+
 TimeBasedValve = time_based_ns.class_(
     "TimeBasedValve", TimeBasedActuatorBase, valve.Valve
 )

…mponents/time_based/time_based_valve.cpp …ts/time_based/valve/time_based_valve.cppesphome/components/time_based/time_based_valve.cpp renamed to esphome/components/time_based/valve/time_based_valve.cpp esphome/components/time_based/time_based_valve.cpp renamed to esphome/components/time_based/valve/time_based_valve.cpp

@@ -15,16 +15,6 @@ void TimeBasedValve::dump_config() {
                 this->open_duration_ / 1e3f, this->close_duration_ / 1e3f);
 }
 
-void TimeBasedValve::setup() {
-  auto restore = this->restore_state_();
-  if (restore.has_value()) {
-    restore->apply(this);
-  } else {
-    this->position = 0.5f;
-    this->publish_state();
-  }
-}
-
 ValveTraits TimeBasedValve::get_traits() {
   auto traits = ValveTraits();
   traits.set_supports_stop(true);

…components/time_based/time_based_valve.h …ents/time_based/valve/time_based_valve.hesphome/components/time_based/time_based_valve.h renamed to esphome/components/time_based/valve/time_based_valve.h esphome/components/time_based/time_based_valve.h renamed to esphome/components/time_based/valve/time_based_valve.h

@@ -1,6 +1,6 @@
 #pragma once
 
-#include "time_based_actuator.h"
+#include "../time_based_actuator.h"
 #include "esphome/components/valve/valve.h"
 
 namespace esphome::time_based {
@@ -10,12 +10,11 @@ namespace esphome::time_based {
 class TimeBasedValve : public TimeBasedActuatorBase, public valve::Valve {
  public:
   TimeBasedValve() { this->set_actuator(this); }
-  void setup() override;
   valve::ValveTraits get_traits() override;
   void dump_config() override;
 
  protected:
-  void control(const valve::ValveCall &call) override { TimeBasedActuatorBase::control(call); }
+  void control(const valve::ValveCall &call) override { TimeBasedActuatorBase::control_(call); }
 };
 
 }  // namespace esphome::time_based

tests/unit_tests/test_time_based_actuator.py

@@ -65,3 +65,40 @@ def test_time_based_cover_component_reachable_transitively(self):
         assert TimeBasedCover.inherits_from(cg.Component), (
             "TimeBasedCover must have Component reachable via TimeBasedActuatorBase"
         )
+
+
+class TestTimeBasedValveInheritance:
+    """TimeBasedValve inherits TimeBasedActuatorBase and Valve."""
+
+    def test_time_based_valve_inherits_actuator_base(self):
+        """Verify TimeBasedValve inherits TimeBasedActuatorBase."""
+        from esphome.components.time_based import TimeBasedActuatorBase
+        from esphome.components.time_based.valve import TimeBasedValve
+
+        assert TimeBasedValve.inherits_from(TimeBasedActuatorBase), (
+            f"TimeBasedValve does not inherit from TimeBasedActuatorBase. "
+            f"TimeBasedValve parents: {getattr(TimeBasedValve, '_parents', 'N/A')}"
+        )
+
+    def test_time_based_valve_inherits_valve(self):
+        """The TimeBasedValve must inherit from Valve."""
+        from esphome.components.time_based.valve import TimeBasedValve
+        from esphome.components.valve import Valve
+
+        assert TimeBasedValve.inherits_from(Valve), (
+            f"TimeBasedValve does not inherit from Valve. "
+            f"TimeBasedValve parents: {getattr(TimeBasedValve, '_parents', 'N/A')}"
+        )
+
+    def test_time_based_valve_component_reachable_transitively(self):
+        """Component is reachable via TimeBasedActuatorBase, not as a direct parent of TimeBasedValve.
+
+        TimeBasedValve's direct parents are TimeBasedActuatorBase and Valve.
+        Component lifecycle flows through TimeBasedActuatorBase.
+        """
+        import esphome.codegen as cg
+        from esphome.components.time_based.valve import TimeBasedValve
+
+        assert TimeBasedValve.inherits_from(cg.Component), (
+            "TimeBasedValve must have Component reachable via TimeBasedActuatorBase"
+        )