Skip to content

Bank Account (Unit Tests) #2406

Open
Open
@igakigongo

Description

@igakigongo

I am not sure if I am doing ti right, but the tests indicate that the cancellation token should be passed from a given source.

We received the following error when we ran your code:

BankAccountTests.cs(158,23): warning xUnit1051: Calls to methods which accept CancellationToken should use TestContext.Current.CancellationToken to allow test cancellation to be more responsive. (https://xunit.net/xunit.analyzers/rules/xUnit1051)

I am sure the test case with the Tasks is the one with the issue, as indicated by the error message.

csharp [Fact(Skip = "Remove this Skip property to run this test")] public async Task Can_handle_concurrent_transactions() { var account = new BankAccount(); account.Open(); for (int i = 0; i < 500; i++) { var tasks = new List<Task>(); tasks.Add(Task.Factory.StartNew(() => { for (int j = 0; j < 100; j++) { account.Deposit(1m); account.Withdraw(1m); } })); await Task.WhenAll(tasks.ToArray()); } Assert.Equal(0m, account.Balance); }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions