You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Fix grammar issues in best-practices.md
* add suggestions from review
* Apply suggestions from code review
Co-authored-by: András B Nagy <[email protected]>
* Apply final suggestion
* Change second 'libraries' reference to 'dependencies'
Co-authored-by: Victor Goff <[email protected]>
* Apply suggestions from code review
Co-authored-by: Isaac Good <[email protected]>
---------
Co-authored-by: András B Nagy <[email protected]>
Co-authored-by: Victor Goff <[email protected]>
Co-authored-by: Isaac Good <[email protected]>
First, the `pre-compiled` directory is copied into the image.
75
-
This directory is setup as a sort of fake exercise and depends on the same base libraries that the actual exercise depend on.
75
+
This directory is set up as a test exercise and depends on the same base libraries that the actual exercise depends on.
76
76
Then we run the tests on that directory, which is similar to how tests are run for an actual exercise.
77
77
Running the tests will result in the base being compiled, but the difference is that this happens at _build time_.
78
-
The resulting Docker image will thus have its base libraries already compiled, which means that no longer has to happen at _run time_, resulting in (much) faster execution times.
78
+
The resulting Docker image will thus have its base libraries already compiled.
79
+
This means compiling is not needed at _run time_, resulting in a (much) faster execution.
79
80
80
81
#### Example: pre-compile binaries
81
82
@@ -117,7 +118,7 @@ node 20.16.0 1.09GB
117
118
node 20.16.0-slim 219MB
118
119
```
119
120
120
-
The reason "slim" variants are smaller is that they'll have less features.
121
+
The reason "slim" variants are smaller is that they have fewer features.
121
122
Your image might not need the additional features, and if not, consider using the "slim" variant.
122
123
123
124
### Removing unneeded bits
@@ -137,7 +138,7 @@ Therefore, any package manager caching/bookkeeping files should be removed after
137
138
138
139
##### apk
139
140
140
-
Distributions that uses the `apk` package manager (such as Alpine) should use the `--no-cache` flag when using `apk add` to install packages:
141
+
Distributions that use the `apk` package manager (such as Alpine) should use the `--no-cache` flag when using `apk add` to install packages:
The Ruby test runner needs the `git`, `openssh`, `build-base`, `gcc` and `wget` packages to be installed before its required libraries (gems) can be installed.
217
-
Its [Dockerfile](https://github.com/exercism/ruby-test-runner/blob/e57ed45b553d6c6411faeea55efa3a4754d1cdbf/Dockerfile) starts with a stage (given the name `build`) that install those packages (via `apk add`) and then installs the libaries (via `bundle install`):
218
+
Its [Dockerfile](https://github.com/exercism/ruby-test-runner/blob/e57ed45b553d6c6411faeea55efa3a4754d1cdbf/Dockerfile) starts with a stage (given the name `build`) that installs those packages (via `apk add`) and then installs the dependencies (via `bundle install`):
0 commit comments