First Class Functions: task 5 misleading test?

[randych-gilad]

At first it was like:

go/exercises/concept/expenses/.docs/instructions.md

Line 144 in 0419fde

When the category is not a category of any of the records (regardless of period of time) the function should return an error.

But then:

go/exercises/concept/expenses/expenses_test.go

Line 224 in 0419fde

name: "returns error when no records with category found in any days period",

which contradicts the "regardless" part.
I think that's human error or just plain misleading.

[github-actions]

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

[andrerfcsantos]

Would changing this to "returns error when no records with category found in any period" (removed the word "days") make it clearer for you?

[randych-gilad]

Yes, I believe so

[andrerfcsantos]

@randych-gilad I'll take a PR for this if you want to make one :)