Skip to content

Commit 41f9f7e

Browse files
committed
implements two missing unit tests
1 parent c386934 commit 41f9f7e

File tree

2 files changed

+40
-3
lines changed

2 files changed

+40
-3
lines changed

exercises/practice/two-bucket/.meta/config.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
"muzimuzhi",
1515
"sjwarner-bp",
1616
"SleeplessByte",
17-
"sshine"
17+
"sshine",
18+
"Xinri"
1819
],
1920
"files": {
2021
"solution": [

exercises/practice/two-bucket/src/test/java/TwoBucketTest.java

Lines changed: 38 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import org.junit.jupiter.api.Disabled;
2+
import org.junit.jupiter.api.DisplayName;
23
import org.junit.jupiter.api.Test;
34

45
import static org.assertj.core.api.Assertions.assertThat;
@@ -7,6 +8,7 @@
78
public class TwoBucketTest {
89

910
@Test
11+
@DisplayName("Measure using bucket one of size 3 and bucket two of size 5 - start with bucket one")
1012
public void testBucketOneSizeThreeBucketTwoSizeFiveStartWithOne() {
1113

1214
Result bucketResult = new TwoBucket(3, 5, 1, "one").getResult();
@@ -19,6 +21,7 @@ public void testBucketOneSizeThreeBucketTwoSizeFiveStartWithOne() {
1921

2022
@Disabled("Remove to run test")
2123
@Test
24+
@DisplayName("Measure using bucket one of size 3 and bucket two of size 5 - start with bucket two")
2225
public void testBucketOneSizeThreeBucketTwoSizeFiveStartWithTwo() {
2326

2427
Result bucketResult = new TwoBucket(3, 5, 1, "two").getResult();
@@ -31,6 +34,7 @@ public void testBucketOneSizeThreeBucketTwoSizeFiveStartWithTwo() {
3134

3235
@Disabled("Remove to run test")
3336
@Test
37+
@DisplayName("Measure using bucket one of size 7 and bucket two of size 11 - start with bucket one")
3438
public void testBucketOneSizeSevenBucketTwoSizeElevenStartWithOne() {
3539

3640
Result bucketResult = new TwoBucket(7, 11, 2, "one").getResult();
@@ -43,6 +47,7 @@ public void testBucketOneSizeSevenBucketTwoSizeElevenStartWithOne() {
4347

4448
@Disabled("Remove to run test")
4549
@Test
50+
@DisplayName("Measure using bucket one of size 7 and bucket two of size 11 - start with bucket two")
4651
public void testBucketOneSizeSevenBucketTwoSizeElevenStartWithTwo() {
4752

4853
Result bucketResult = new TwoBucket(7, 11, 2, "two").getResult();
@@ -55,6 +60,7 @@ public void testBucketOneSizeSevenBucketTwoSizeElevenStartWithTwo() {
5560

5661
@Disabled("Remove to run test")
5762
@Test
63+
@DisplayName("Measure one step using bucket one of size 1 and bucket two of size 3 - start with bucket two")
5864
public void testBucketOneSizeOneBucketTwoSizeThreeStartWithTwo() {
5965

6066
Result bucketResult = new TwoBucket(1, 3, 3, "two").getResult();
@@ -67,6 +73,7 @@ public void testBucketOneSizeOneBucketTwoSizeThreeStartWithTwo() {
6773

6874
@Disabled("Remove to run test")
6975
@Test
76+
@DisplayName("Measure using bucket one of size 2 and bucket two of size 3 - start with bucket one and end with bucket two")
7077
public void testBucketOneSizeTwoBucketTwoSizeThreeStartWithOne() {
7178

7279
Result bucketResult = new TwoBucket(2, 3, 3, "one").getResult();
@@ -79,15 +86,43 @@ public void testBucketOneSizeTwoBucketTwoSizeThreeStartWithOne() {
7986

8087
@Disabled("Remove to run test")
8188
@Test
89+
@DisplayName("Measure using bucket one much bigger than bucket two")
90+
public void testBucketOneMuchBiggerThanBucketTwo() {
91+
92+
Result bucketResult = new TwoBucket(5, 1, 2, "one").getResult();
93+
94+
assertThat(bucketResult.getTotalMoves()).isEqualTo(6);
95+
assertThat(bucketResult.getFinalBucket()).isEqualTo("one");
96+
assertThat(bucketResult.getOtherBucket()).isEqualTo(1);
97+
98+
}
99+
100+
@Disabled("Remove to run test")
101+
@Test
102+
@DisplayName("Measure using bucket one much smaller than bucket two")
103+
public void testBucketOneMuchSmallerThanBucketTwo() {
104+
105+
Result bucketResult = new TwoBucket(3, 15, 9, "one").getResult();
106+
107+
assertThat(bucketResult.getTotalMoves()).isEqualTo(6);
108+
assertThat(bucketResult.getFinalBucket()).isEqualTo("two");
109+
assertThat(bucketResult.getOtherBucket()).isEqualTo(0);
110+
111+
}
112+
113+
@Disabled("Remove to run test")
114+
@Test
115+
@DisplayName("Not possible to reach the goal")
82116
public void testReachingGoalIsImpossible() {
83-
117+
84118
assertThatExceptionOfType(UnreachableGoalException.class)
85119
.isThrownBy(() -> new TwoBucket(6, 15, 5, "one").getResult());
86120

87121
}
88122

89123
@Disabled("Remove to run test")
90124
@Test
125+
@DisplayName("With the same buckets but a different goal, then it is possible")
91126
public void testBucketOneSizeSixBucketTwoSizeFifteenStartWithOne() {
92127

93128
Result bucketResult = new TwoBucket(6, 15, 9, "one").getResult();
@@ -96,10 +131,11 @@ public void testBucketOneSizeSixBucketTwoSizeFifteenStartWithOne() {
96131
assertThat(bucketResult.getFinalBucket()).isEqualTo("two");
97132
assertThat(bucketResult.getOtherBucket()).isEqualTo(0);
98133

99-
}
134+
}
100135

101136
@Disabled("Remove to run test")
102137
@Test
138+
@DisplayName("Goal larger than both buckets is impossible")
103139
public void testGoalLargerThanBothBucketsIsImpossible() {
104140

105141
assertThatExceptionOfType(UnreachableGoalException.class)

0 commit comments

Comments
 (0)