diff --git a/lib/analyzers/two_fer/analyze.rb b/lib/analyzers/two_fer/analyze.rb index da4f30f..4971101 100644 --- a/lib/analyzers/two_fer/analyze.rb +++ b/lib/analyzers/two_fer/analyze.rb @@ -173,10 +173,10 @@ def refer_to_mentor! raise FinishedFlowControlException end - def disapprove!(msg, *msg_args) + def disapprove!(msg, params = {}) self.status = :disapprove - if msg_args.length > 0 - self.comments << [MESSAGES[msg], *msg_args] + if params.length > 0 + self.comments << {comment: MESSAGES[msg], params: params} else self.comments << MESSAGES[msg] end diff --git a/test/exercises/two_fer_test.rb b/test/exercises/two_fer_test.rb index 03008b1..432ca9d 100644 --- a/test/exercises/two_fer_test.rb +++ b/test/exercises/two_fer_test.rb @@ -140,7 +140,8 @@ def self.two_fer(*foos) } results = TwoFer::Analyze.(source) assert_equal :disapprove, results[:status] - assert_equal [["ruby.two-fer.splat_args", name_variable: :foos]], results[:comments] + assert_equal [{comment: "ruby.two-fer.splat_args", params: {name_variable: :foos}}], results[:comments] + end # ###