NoMethodError in AwardReputationForPullRequestJob@reputation

[iHiD]

Error in v3

NoMethodError in AwardReputationForPullRequestJob@reputation
undefined method `iso8601' for nil:NilClass

View on Bugsnag

Stacktrace

app/models/user/reputation_token.rb:91 - cacheable_rendering_data
app/models/concerns/is_paramaterised_sti.rb:79 - block (2 levels) in <module:IsParamaterisedSTI>
app/commands/user/reputation_token/create.rb:15 - block in call
app/commands/user/reputation_token/create.rb:14 - tap
app/commands/user/reputation_token/create.rb:14 - call
app/commands/user/reputation_token/award_for_pull_request_reviewers.rb:26 - block in call
app/commands/user/reputation_token/award_for_pull_request_reviewers.rb:25 - call
app/commands/user/reputation_token/award_for_pull_request.rb:10 - call
app/jobs/award_reputation_for_pull_request_job.rb:5 - perform

View full stacktrace

Created automatically via Bugsnag

[iHiD]

@ErikSchierboom So earned_on is nil for reviewer reputation tokens.

From reading the data (see below) it looks like closed_at isn't there as a key. And because the PR was closed un-merged, it breaks:

{
  "retry": true,
  "queue": "reputation",
  "class": "ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper",
  "wrapped": "AwardReputationForPullRequestJob",
  "args": [
    {
      "job_class": "AwardReputationForPullRequestJob",
      "job_id": "469fe493-6e04-4cce-9c9a-acd8ef15f45a",
      "provider_job_id": null,
      "queue_name": "reputation",
      "priority": null,
      "arguments": [
        {
          "action": "closed",
          "author_username": "yawpitch",
          "url": "https://api.github.com/repos/exercism/python/pulls/1547",
          "html_url": "https://github.com/exercism/python/pull/1547",
          "labels": [],
          "state": "closed",
          "node_id": "MDExOlB1bGxSZXF1ZXN0MjE5NzkwMDQ2",
          "number": 1547,
          "title": "[WIP] Add Python test generator",
          "repo": "exercism/python",
          "created_at": "2018-10-02T17:49:18.000Z",
          "merged": false,
          "merged_at": null,
          "merged_by_username": null,
          "reviews": [
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYyNDQ4OTAx",
              "submitted_at": "2018-10-08T12:35:06.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYyNjA3NzY0",
              "submitted_at": "2018-10-08T19:24:23.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYyNjE3NDQw",
              "submitted_at": "2018-10-08T20:01:52.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYyNjMxMTc3",
              "submitted_at": "2018-10-08T20:39:31.000Z",
              "reviewer_username": "yawpitch",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYyNjMxNjE0",
              "submitted_at": "2018-10-08T20:40:52.000Z",
              "reviewer_username": "yawpitch",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYyOTAwODg2",
              "submitted_at": "2018-10-09T13:52:51.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYyOTk0Nzg1",
              "submitted_at": "2018-10-09T16:57:26.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYzMDIyNTQ4",
              "submitted_at": "2018-10-09T18:02:08.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYzMDI0NTE2",
              "submitted_at": "2018-10-09T18:06:51.000Z",
              "reviewer_username": "yawpitch",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYzMDI3NjE1",
              "submitted_at": "2018-10-09T18:14:31.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYzMDU1MDM2",
              "submitted_at": "2018-10-09T19:20:57.000Z",
              "reviewer_username": "yawpitch",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYzMDU4Mjc4",
              "submitted_at": "2018-10-09T19:29:26.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYzMDY2Mjc5",
              "submitted_at": "2018-10-09T19:50:15.000Z",
              "reviewer_username": "yawpitch",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYzMDY4MDEz",
              "submitted_at": "2018-10-09T19:54:32.000Z",
              "reviewer_username": "yawpitch",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYzMDY4Mjkx",
              "submitted_at": "2018-10-09T19:55:11.000Z",
              "reviewer_username": "yawpitch",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTYzMzIyNjE5",
              "submitted_at": "2018-10-10T12:16:00.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTY0NDY4ODE1",
              "submitted_at": "2018-10-13T16:40:28.000Z",
              "reviewer_username": "yawpitch",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTY0ODE1ODM2",
              "submitted_at": "2018-10-15T17:35:50.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTgzNzI5NzQ5",
              "submitted_at": "2018-12-11T15:15:26.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTgzNzMwMTEw",
              "submitted_at": "2018-12-11T15:25:05.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTgzNzM2ODQw",
              "submitted_at": "2018-12-11T15:27:43.000Z",
              "reviewer_username": "yawpitch",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTgzNzM3NDYz",
              "submitted_at": "2018-12-11T15:28:56.000Z",
              "reviewer_username": "yawpitch",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTgzNzM5ODYz",
              "submitted_at": "2018-12-11T15:33:02.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTgzNzQwNzA5",
              "submitted_at": "2018-12-11T15:34:23.000Z",
              "reviewer_username": "yawpitch",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTg4NjkyNjU1",
              "submitted_at": "2019-01-02T16:17:32.000Z",
              "reviewer_username": "cmccandless",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            },
            {
              "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTg5NjI3NzM5",
              "submitted_at": "2019-01-06T12:23:40.000Z",
              "reviewer_username": "yawpitch",
              "_aj_symbol_keys": [
                "node_id",
                "submitted_at",
                "reviewer_username"
              ]
            }
          ],
          "_aj_symbol_keys": [
            "action",
            "author_username",
            "url",
            "html_url",
            "labels",
            "state",
            "node_id",
            "number",
            "title",
            "repo",
            "created_at",
            "merged",
            "merged_at",
            "merged_by_username",
            "reviews"
          ]
        }
      ],
      "executions": 0,
      "exception_executions": {},
      "locale": "en",
      "timezone": "UTC",
      "enqueued_at": "2021-06-28T01:51:46Z"
    }
  ],
  "jid": "2326068c6e10d3617f338934",
  "created_at": 1624845106.952255,
  "enqueued_at": 1624941837.427023,
  "error_message": "undefined method `iso8601' for nil:NilClass",
  "error_class": "NoMethodError",
  "failed_at": 1624941837.837569,
  "retry_count": 13,
  "retried_at": 1624912996.517028,
  "processor": "ip-10-1-0-24.eu-west-2.compute.internal:1"
}

[iHiD]

An error linked to this issue has been reopened in Bugsnag
NoMethodError in AwardReputationForPullRequestJob@reputation

[iHiD]

@ErikSchierboom Not sure if this reopened before or after your script ran?

[ErikSchierboom]

Not sure either 🤷

[iHiD]

Let's see if it reopens.

[iHiD]

An error linked to this issue has been reopened in Bugsnag
NoMethodError in AwardReputationForPullRequestJob@reputation

[iHiD]

Let's try again.