fix(drivers): boot port must always use network-type interface

LibvirtPoolDriver.create_machine() applied the hypervisor's own
network_type (bridge/network) to every port it's given, including the
initial boot-network port. The boot network is always a plain libvirt
virtual network regardless of the hypervisor's main network type, so
on a bridge-type hypervisor libvirt tried to treat the boot network's
name as a literal host bridge device name and rejected it as too long
for IFNAMSIZ.

Only force type='network' for the boot-network port specifically
(identified via the new BOOT_NETWORK_PORT_UUID sentinel, see
Port.from_boot_network()). Any other port - including the real port(s)
create_machine() is given when recreate_machine() rebuilds the domain
post-flash - keeps honoring network_type, since real bridge-type
hypervisors do use raw bridge-type interfaces (source=<bridge device>),
not a libvirt network wrapping one.

attach_port(), used only for the real port, is unaffected.

Author: VasilyStepanov

exordos_core/compute/constants.py

@@ -26,6 +26,11 @@
 
 NODE_SET_PROJECT = sys_uuid.UUID("11111113-bc70-4760-9fbf-9fcfe40da329")
 
+# Sentinel UUID for the transient boot-network port (see
+# Port.from_boot_network()) - a real UUID doesn't make sense for it since
+# it's replaced once the machine is flashed.
+BOOT_NETWORK_PORT_UUID = sys_uuid.UUID("00000000-0000-0000-0000-000000000000")
+
 
 BootType = tp.Literal["hd", "network", "cdrom"]
 

exordos_core/compute/dm/models.py

@@ -769,9 +769,9 @@ def from_boot_network(cls):
             }
         )
         return cls(
-            # The UUID is not important for port in boot network.
-            # It is just a placeholder.
-            uuid=sys_uuid.UUID("00000000-0000-0000-0000-000000000000"),
+            # The pool driver relies on this specific UUID to recognize the
+            # port as the transient boot network (see LibvirtPoolDriver).
+            uuid=nc.BOOT_NETWORK_PORT_UUID,
             project_id=cc.SERVICE_PROJECT_ID,
             name="bootnet_port",
             subnet=boot_subnet.uuid,

exordos_core/compute/pool/drivers/libvirt.py

@@ -1198,13 +1198,8 @@ def attach_port(self, machine: models.Machine, port: models.Port) -> None:
             raise
 
         # Build interface XML
-        # Always type='network': `port.source` is the logical libvirt
-        # network name the orchestrator tracks (see create_machine), not
-        # necessarily a literal host bridge device - a bridge-type
-        # hypervisor still needs it resolved through a local libvirt
-        # network that forwards onto the real bridge.
         interface_xml = XMLLibvirtInstance.interface_xml(
-            iface_type="network",
+            iface_type=self._spec.network_type,
             mac=port.mac,
             rom=self._spec.iface_rom_file,
             mtu=self._spec.iface_mtu,
@@ -1303,12 +1298,17 @@ def create_machine(
                 mac=port.mac,
                 rom=self._spec.iface_rom_file,
                 mtu=self._spec.iface_mtu,
-                # Always type='network': `port.source` is a logical
-                # libvirt network name the orchestrator tracks (the boot
-                # network at initial creation, or the main network when
-                # recreate_machine() rebuilds the domain post-flash), not
-                # necessarily a literal host bridge device.
-                iface_type="network",
+                # The boot-network port (see Port.from_boot_network()) is
+                # always a transient libvirt-managed network, regardless of
+                # the hypervisor's own network_type - unlike the real
+                # port(s) attached once the machine is flashed
+                # (recreate_machine()), which must honor it (e.g. a raw
+                # host bridge on bridge-type hypervisors).
+                iface_type=(
+                    "network"
+                    if port.uuid == nc.BOOT_NETWORK_PORT_UUID
+                    else self._spec.network_type
+                ),
                 source=port.source,
             )