Code_review #5
Open
Code_review #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle network errors from Jina's side
The changes here were done before the code_review branch was created. They are being added here to streamline the next PR to include all updates from @exowanderer
…ased on flake8 results
…ath.append operation in run.py
…on flake8; add PYTHONPATH to docker/2_Data_Processing_save_items_per_lang/Docker
…dd PYTHONPATH to docker/2_Data_Processing_save_items_per_lang/Docker
…TH=':/'; update use of src. in various python imports; update use of src. in src.language_variables.
- Improved cache db operations and fixed errors involve db insertion - Improved data storage by storing the smaller base64 data per embedding, which results directly from JinaAI's API - Refactored handling of DataStax and JinaAI errors - Fixed duplicate ID errors - updated our caching and merging of cache - created migrate_db routine to update from original to smaller db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started code review before branch was created
Now includes updates to
docker-compose.yml
docker7 run.py
wikidataItemDB
wikidataRetriever