Address length used to copy array in FacetsCollector to not be out of bounds (apache#13774)

javanna · web-flow · commit aa86c2b8a049 · 2024-09-12T13:08:44.000+02:00
This has caused a few recent test failures with jdk23 and jdk24. It should
get fixed replacing the length with the lengt of the array, rather than using
the new length.
diff --git a/lucene/facet/src/java/org/apache/lucene/facet/FacetsCollector.java b/lucene/facet/src/java/org/apache/lucene/facet/FacetsCollector.java
@@ -84,7 +84,7 @@ public void collect(int doc) throws IOException {
     if (keepScores) {
       if (doc >= scores.length) {
         float[] newScores = new float[ArrayUtil.oversize(doc + 1, 4)];
-        System.arraycopy(scores, 0, newScores, 0, doc);
+        System.arraycopy(scores, 0, newScores, 0, scores.length);
         scores = newScores;
       }
       scores[doc] = scorer.score();

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ public void collect(int doc) throws IOException {`
`84`	`84`	`if (keepScores) {`
`85`	`85`	`if (doc >= scores.length) {`
`86`	`86`	`float[] newScores = new float[ArrayUtil.oversize(doc + 1, 4)];`
`87`		`- System.arraycopy(scores, 0, newScores, 0, doc);`
	`87`	`+ System.arraycopy(scores, 0, newScores, 0, scores.length);`
`88`	`88`	`scores = newScores;`
`89`	`89`	`}`
`90`	`90`	`scores[doc] = scorer.score();`