Skip to content

Commit 7e8642f

Browse files
author
Boris van Katwijk
committed
[BUGFIX][PWAI-716] Avoid unused variables; see details below.
lib/experius/module-postcode/Block/Checkout/LayoutProcessor.php:103 - UnusedLocalVariable Avoid unused local variables such as '$paymentMethodValue'. lib/experius/module-postcode/Block/System/Config/Form/Apikey/Checker.php:32 - UnusedFormalParameter Avoid unused parameters such as '$element'. lib/experius/module-postcode/Console/Command/Test.php:41 - UnusedLocalVariable Avoid unused local variables such as '$vat'. lib/experius/module-postcode/Console/Command/Test.php:42 - UnusedLocalVariable Avoid unused local variables such as '$option'.
1 parent d83d6d5 commit 7e8642f

File tree

4 files changed

+74
-7
lines changed

4 files changed

+74
-7
lines changed

Block/Checkout/LayoutProcessor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public function getBillingFormFields($result)
100100
['billing-step']['children']['payment']['children']
101101
['payments-list']['children'];
102102

103-
foreach ($paymentForms as $paymentMethodForm => $paymentMethodValue) {
103+
foreach (array_keys($paymentForms) as $paymentMethodForm) {
104104
$paymentMethodCode = str_replace('-form', '', $paymentMethodForm);
105105

106106
if (!isset($result['components']['checkout']['children']['steps']['children']['billing-step']

Block/System/Config/Form/Apikey/Checker.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@ public function render(AbstractElement $element)
2929
return parent::render($element);
3030
}
3131

32+
/**
33+
* @param AbstractElement $element
34+
* @return string
35+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
36+
*/
3237
protected function _getElementHtml(AbstractElement $element)
3338
{
3439
return $this->_toHtml();

CHANGELOG.md

Lines changed: 65 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,61 @@
1+
## 1.11.0 (2022-10-17)
2+
3+
[View Release]([email protected]:experius/Magento-2-Module-Experius-Postcode-NL.git/commits/tag/1.11.0)
4+
5+
* [BUGFIX][PWAI-716] Avoid unused variables; see details below. *(Boris van Katwijk)*
6+
7+
8+
## 1.10.0 (2022-09-06)
9+
10+
[View Release]([email protected]:experius/Magento-2-Module-Experius-Postcode-NL.git/commits/tag/1.10.0)
11+
12+
* Changed function because ReadOnly Class can not be used in PHP8.1 *(Demi Holland)*
13+
* Edit trim function because PHP8.1 compatibility *(Demi Holland)*
14+
15+
16+
## 1.9.0 (2021-07-15)
17+
18+
[View Release]([email protected]:experius/Magento-2-Module-Experius-Postcode-NL.git/commits/tag/1.9.0)
19+
20+
* [FEATURE][DRRS-47] - Updated postcode api url with new url to keep continued support *(Rens Wolters)*
21+
22+
23+
## 1.8.2 (2021-05-12)
24+
25+
[View Release]([email protected]:experius/Magento-2-Module-Experius-Postcode-NL.git/commits/tag/1.8.2)
26+
27+
* [BUGFIX] - Fix housenumber addition *(Ruben Panis)*
28+
29+
30+
## 1.8.1 (2021-02-01)
31+
32+
[View Release]([email protected]:experius/Magento-2-Module-Experius-Postcode-NL.git/commits/tag/1.8.1)
33+
34+
* [BUGFIX] Solved "TypeError: Cannot read property 'get' of undefined" when country is set to Belgium *(Mr. Lewis)*
35+
36+
37+
## 1.8.0 (2020-10-28)
38+
39+
[View Release]([email protected]:experius/Magento-2-Module-Experius-Postcode-NL.git/commits/tag/1.8.0)
40+
41+
* [FEATURE] Introduce pluggable function to alter sort order of the postcode fields for different checkouts than the default Magento OnePage. *(Boris van Katwijk)*
42+
43+
44+
## 1.7.0 (2020-10-05)
45+
46+
[View Release]([email protected]:experius/Magento-2-Module-Experius-Postcode-NL.git/commits/tag/1.7.0)
47+
48+
* [FEATURE]Added pattern to housenumber input for numeric keyboard on ios *(joeydankbaar)*
49+
50+
51+
## 1.6.0 (2020-10-02)
52+
53+
[View Release]([email protected]:experius/Magento-2-Module-Experius-Postcode-NL.git/commits/tag/1.6.0)
54+
55+
* [DOCS] Updated the CHANGELOG.md *(Lewis Voncken)*
56+
* [FEATURE] Split GraphQl functionality from module *(René Schep)*
57+
58+
159
## 1.5.0 (2020-10-01)
260

361
[View Release]([email protected]:experius/Magento-2-Module-Experius-Postcode-NL.git/commits/tag/1.5.0)
@@ -19,12 +77,18 @@
1977

2078
[View Release]([email protected]:experius/Magento-2-Module-Experius-Postcode-NL.git/commits/tag/1.4.1)
2179

80+
* [FEATURE] Updated GraphQl Exception type for lookupAddress errors *(René Schep)*
81+
82+
83+
## 1.4.0 (2020-09-15)
84+
85+
[View Release]([email protected]:experius/Magento-2-Module-Experius-Postcode-NL.git/commits/tag/1.4.0)
86+
2287
* [DOC] Cleaned some code *(René Schep)*
2388
* [FEATURE] Added support for GraphQl *(René Schep)*
2489
* [FEATURE] Added magento version restriction *(René Schep)*
2590
* [BUGFIX] Typo *(René Schep)*
2691
* [BUGFIX] Fixed version restraint *(René Schep)*
27-
* [FEATURE] Updated GraphQl Exception type for lookupAddress errors *(René Schep)*
2892

2993

3094
## 1.3.4 (2020-04-09)

Console/Command/Test.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,15 @@ public function __construct(
3434
parent::__construct('test');
3535
}
3636

37+
/**
38+
* @inheritDoc
39+
*/
3740
protected function execute(
3841
InputInterface $input,
3942
OutputInterface $output
4043
) {
41-
$vat = $input->getArgument(self::NAME_ARGUMENT);
42-
$option = $input->getOption(self::NAME_OPTION);
43-
44-
4544
print_r($this->postcodeHelper->getJsinit(false));
4645

47-
4846
$testAddresses = [
4947
'3512VT' => '6'
5048
];

0 commit comments

Comments
 (0)