Suppress build warnings#156
Open
rgommers wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
A few more. On Ubuntu arm64 (log): On macOS arm64 (log), lots of this: On Windows (log), deprecation warnings for Details |
Replace the deprecated "License :: OSI Approved :: BSD License" classifier with the SPDX license identifier "BSD-3-Clause". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The const pointer wrappers (dgemm, sgemm, saxpy, daxpy) call fused-type functions that can't express const, producing -Wdiscarded-qualifiers warnings. Suppress with both the gcc and clang flag variants, and add -Wno-unknown-warning-option so clang doesn't warn about the gcc flag. Also suppress `-Wunused-function` warnings, they show up on macOS (not on Linux). Finally suppress a warning for `py.pyx` about using deprecated NumPy C API (should be harmless, but good to avoid it). Overall this should cut the length of CI logs roughly in half. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
BLIS objects are compiled via raw subprocess calls that don't inherit Python's deployment target, defaulting to the SDK version (e.g. 15.0). When distutils links the extension with a lower target (e.g. 11.0), the linker warns about version mismatches. Fix by setting MACOSX_DEPLOYMENT_TARGET from sysconfig before compiling. Avoids lots of warnings like this in the regular macOS CI jobs: ``` ld: warning: object file (.../bli_cntx_init_generic.o) was built for newer 'macOS' version (15.0) than being linked (11.0) ``` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rgommers
force-pushed
the
suppress-build-warnings
branch
from
fa21d14 to
6e7f646
Compare
Contributor
Author
|
Close/reopen to re-run CI, after some other build fixes were just merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(1) Suppress discarded-qualifiers warnings in Cython extensions
The const pointer wrappers (dgemm, sgemm, saxpy, daxpy) call fused-type
functions that can't express const, producing -Wdiscarded-qualifiers
warnings. Suppress with both the gcc and clang flag variants, and add
-Wno-unknown-warning-option so clang doesn't warn about the gcc flag.
(2) Also suppress
-Wunused-functionwarnings, they show up on macOS(not on Linux).
(3) Use an SPDX expression for the license instead of a deprecated trove classifier
license warning content
Overall this should cut the length of CI logs roughly in half.