Skip to content

Commit 2a5a88d

Browse files
committed
[eas-cli] Narrow amount of data queried for basic update channel operations
1 parent 911cc90 commit 2a5a88d

File tree

9 files changed

+53
-12
lines changed

9 files changed

+53
-12
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ This is the log of notable changes to EAS CLI and related packages.
1212

1313
### 🧹 Chores
1414

15+
- Narrow amount of data queried for basic update channel operations. ([#2901](https://github.com/expo/eas-cli/pull/2901) by [@wschurman](https://github.com/wschurman))
16+
1517
## [15.0.10](https://github.com/expo/eas-cli/releases/tag/v15.0.10) - 2025-02-11
1618

1719
### 🐛 Bug fixes

packages/eas-cli/graphql.schema.json

Lines changed: 0 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/eas-cli/src/channel/queries.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ export async function doesChannelExistAsync(
289289
{ appId, channelName }: { appId: string; channelName: string }
290290
): Promise<boolean> {
291291
try {
292-
await ChannelQuery.viewUpdateChannelAsync(graphqlClient, {
292+
await ChannelQuery.viewUpdateChannelBasicInfoAsync(graphqlClient, {
293293
appId,
294294
channelName,
295295
});

packages/eas-cli/src/commands/channel/delete.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export default class ChannelDelete extends EasCommand {
5252

5353
let channelId, channelName;
5454
if (nameArg) {
55-
const { id, name } = await ChannelQuery.viewUpdateChannelAsync(graphqlClient, {
55+
const { id, name } = await ChannelQuery.viewUpdateChannelBasicInfoAsync(graphqlClient, {
5656
appId: projectId,
5757
channelName: nameArg,
5858
});

packages/eas-cli/src/commands/channel/edit.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export default class ChannelEdit extends EasCommand {
9494
}
9595

9696
const existingChannel = args.name
97-
? await ChannelQuery.viewUpdateChannelAsync(graphqlClient, {
97+
? await ChannelQuery.viewUpdateChannelBasicInfoAsync(graphqlClient, {
9898
appId: projectId,
9999
channelName: args.name,
100100
})

packages/eas-cli/src/commands/channel/pause.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export default class ChannelPause extends EasCommand {
8686
}
8787

8888
const existingChannel = args.name
89-
? await ChannelQuery.viewUpdateChannelAsync(graphqlClient, {
89+
? await ChannelQuery.viewUpdateChannelBasicInfoAsync(graphqlClient, {
9090
appId: projectId,
9191
channelName: args.name,
9292
})

packages/eas-cli/src/commands/channel/resume.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export default class ChannelResume extends EasCommand {
8686
}
8787

8888
const existingChannel = args.name
89-
? await ChannelQuery.viewUpdateChannelAsync(graphqlClient, {
89+
? await ChannelQuery.viewUpdateChannelBasicInfoAsync(graphqlClient, {
9090
appId: projectId,
9191
channelName: args.name,
9292
})

packages/eas-cli/src/graphql/generated.ts

Lines changed: 8 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/eas-cli/src/graphql/queries/ChannelQuery.ts

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import { withErrorHandlingAsync } from '../client';
77
import {
88
UpdateBranchBasicInfoFragment,
99
UpdateFragment,
10+
ViewUpdateChannelBasicInfoOnAppQuery,
11+
ViewUpdateChannelBasicInfoOnAppQueryVariables,
1012
ViewUpdateChannelOnAppQuery,
1113
ViewUpdateChannelOnAppQueryVariables,
1214
ViewUpdateChannelsOnAppQuery,
@@ -41,6 +43,42 @@ export function composeUpdateBranchObject(
4143
}
4244

4345
export const ChannelQuery = {
46+
async viewUpdateChannelBasicInfoAsync(
47+
graphqlClient: ExpoGraphqlClient,
48+
{ appId, channelName }: ViewUpdateChannelBasicInfoOnAppQueryVariables
49+
): Promise<
50+
NonNullable<ViewUpdateChannelBasicInfoOnAppQuery['app']['byId']['updateChannelByName']>
51+
> {
52+
const response = await withErrorHandlingAsync(
53+
graphqlClient
54+
.query<ViewUpdateChannelBasicInfoOnAppQuery, ViewUpdateChannelBasicInfoOnAppQueryVariables>(
55+
gql`
56+
query ViewUpdateChannelBasicInfoOnApp($appId: String!, $channelName: String!) {
57+
app {
58+
byId(appId: $appId) {
59+
id
60+
updateChannelByName(name: $channelName) {
61+
id
62+
...UpdateChannelBasicInfoFragment
63+
}
64+
}
65+
}
66+
}
67+
${print(UpdateChannelBasicInfoFragmentNode)}
68+
`,
69+
{ appId, channelName },
70+
{ additionalTypenames: ['UpdateChannel', 'UpdateBranch', 'Update'] }
71+
)
72+
.toPromise()
73+
);
74+
75+
const { updateChannelByName } = response.app.byId;
76+
if (!updateChannelByName) {
77+
throw new ChannelNotFoundError(`Could not find channel with the name ${channelName}`);
78+
}
79+
80+
return updateChannelByName;
81+
},
4482
async viewUpdateChannelAsync(
4583
graphqlClient: ExpoGraphqlClient,
4684
{ appId, channelName, filter }: ViewUpdateChannelOnAppQueryVariables

0 commit comments

Comments
 (0)