You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<!-- If this PR requires a changelog entry, add it by commenting the PR with the command `/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]`. -->
<!-- You can skip the changelog check by labeling the PR with "no changelog". -->
# Why
`fs-extra` fails to copy symbolic links as one would expect. jprichardson/node-fs-extra#708
# How
We could:
- copy and dereference symbolic links — make it so that the clone of the original directory has two copies of the files -- original and linked
- copy symbolic links without re-resolving, assuming any links will be relative and should work when unpacked on a different machine.
I think we can count on the latter.
# Test Plan
Created a link in my test repository
```
drwxr-xr-x 7 sjchmiela staff 224B Jan 28 16:14 assets
lrwxr-xr-x 1 sjchmiela staff 6B Feb 4 22:12 assets-linked -> assets
```
ran
```
easd build:inspect -p android -s archive -o ~/testtest --force
```
confirmed I see
```
drwxr-xr-x 7 sjchmiela staff 224B Feb 4 22:20 assets
lrwxr-xr-x 1 sjchmiela staff 6B Feb 4 22:20 assets-linked -> assets
```
in the result directory.
Copy file name to clipboardExpand all lines: CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -11,6 +11,7 @@ This is the log of notable changes to EAS CLI and related packages.
11
11
### 🐛 Bug fixes
12
12
13
13
- Fixed `GitClient` not respecting `.easignore` file. ([#2873](https://github.com/expo/eas-cli/pull/2873) by [@sjchmiela](https://github.com/sjchmiela))
14
+
- Fix symlink support in `makeShallowCopyAsync`. ([#2874](https://github.com/expo/eas-cli/pull/2874) by [@sjchmiela](https://github.com/sjchmiela))
0 commit comments