cleanup warnings

Author: mjaric

apps/lora/.formatter.exs

@@ -1,5 +1,4 @@
 [
-  import_deps: [:ecto, :ecto_sql],
   subdirectories: ["priv/*/migrations"],
   plugins: [Phoenix.LiveView.HTMLFormatter],
   inputs: ["*.{heex,ex,exs}", "{config,lib,test}/**/*.{heex,ex,exs}", "priv/*/seeds.exs"]

apps/lora/lib/lora/contract.ex

@@ -3,9 +3,24 @@ defmodule Lora.Contract do
   Defines the seven contracts of the Lora card game and their scoring rules.
   """
 
-  @type t :: :minimum | :maximum | :queens | :hearts | :jack_of_clubs | :king_hearts_last_trick | :lora
+  @type t ::
+          :minimum
+          | :maximum
+          | :queens
+          | :hearts
+          | :jack_of_clubs
+          | :king_hearts_last_trick
+          | :lora
 
-  @contracts [:minimum, :maximum, :queens, :hearts, :jack_of_clubs, :king_hearts_last_trick, :lora]
+  @contracts [
+    :minimum,
+    :maximum,
+    :queens,
+    :hearts,
+    :jack_of_clubs,
+    :king_hearts_last_trick,
+    :lora
+  ]
 
   @doc """
   Returns all available contracts in their fixed order.
@@ -40,10 +55,19 @@ defmodule Lora.Contract do
   def description(:minimum), do: "Plus one point per trick taken"
   def description(:maximum), do: "Minus one point per trick taken"
   def description(:queens), do: "Plus two points per queen taken"
-  def description(:hearts), do: "Plus one point per heart taken; minus eight if one player takes all hearts"
+
+  def description(:hearts),
+    do: "Plus one point per heart taken; minus eight if one player takes all hearts"
+
   def description(:jack_of_clubs), do: "Plus eight points to the player who takes it"
-  def description(:king_hearts_last_trick), do: "Plus four points each for King of Hearts and Last Trick; plus eight if captured in the same trick"
-  def description(:lora), do: "Minus eight to the first player who empties hand; all others receive plus one point per remaining card"
+
+  def description(:king_hearts_last_trick),
+    do:
+      "Plus four points each for King of Hearts and Last Trick; plus eight if captured in the same trick"
+
+  def description(:lora),
+    do:
+      "Minus eight to the first player who empties hand; all others receive plus one point per remaining card"
 
   @doc """
   Returns whether the contract is a trick-taking contract or Lora.

apps/lora/lib/lora/contracts/hearts.ex

@@ -7,7 +7,7 @@ defmodule Lora.Contracts.Hearts do
 
   @behaviour Lora.Contracts.ContractBehaviour
 
-  alias Lora.{Game, Score}
+  alias Lora.Score
   alias Lora.Contracts.TrickTaking
 
   @impl true

apps/lora/lib/lora/contracts/jack_of_clubs.ex

@@ -6,7 +6,7 @@ defmodule Lora.Contracts.JackOfClubs do
 
   @behaviour Lora.Contracts.ContractBehaviour
 
-  alias Lora.{Game, Score}
+  alias Lora.Score
   alias Lora.Contracts.TrickTaking
 
   @impl true

apps/lora/lib/lora/contracts/king_hearts_last_trick.ex

@@ -7,7 +7,7 @@ defmodule Lora.Contracts.KingHeartsLastTrick do
 
   @behaviour Lora.Contracts.ContractBehaviour
 
-  alias Lora.{Game, Score}
+  alias Lora.Score
   alias Lora.Contracts.TrickTaking
 
   @impl true

apps/lora/lib/lora/contracts/lora.ex

@@ -12,7 +12,7 @@ defmodule Lora.Contracts.Lora do
   @impl true
   def is_legal_move?(state, seat, {suit, rank}) do
     layout = state.lora_layout
-    hand = state.hands[seat]
+    _hand = state.hands[seat]
 
     # If this is the first card played in Lora, any card is legal
     if Enum.all?(layout, fn {_, cards} -> cards == [] end) do
@@ -32,8 +32,10 @@ defmodule Lora.Contracts.Lora do
             |> Enum.find(fn _ -> true end)
 
           case any_laid_card do
-            nil -> true  # No cards played yet
-            {_, first_rank} -> rank == first_rank  # Must match the first played card's rank
+            # No cards played yet
+            nil -> true
+            # Must match the first played card's rank
+            {_, first_rank} -> rank == first_rank
           end
 
         # Cards of this suit already played, card must be the next in sequence
@@ -59,11 +61,7 @@ defmodule Lora.Contracts.Lora do
       {next_player, can_anyone_play} = find_next_player_who_can_play(state, hands, seat)
 
       if can_anyone_play do
-        {:ok, %{state |
-          hands: hands,
-          lora_layout: lora_layout,
-          current_player: next_player
-        }}
+        {:ok, %{state | hands: hands, lora_layout: lora_layout, current_player: next_player}}
       else
         # No one can play, the deal is over
         deal_over_state = handle_lora_winner(state, hands, seat)
@@ -156,20 +154,17 @@ defmodule Lora.Contracts.Lora do
 
     # Check if the game is over
     if Game.game_over?(state) do
-      %{state |
-        hands: hands,
-        scores: updated_scores,
-        phase: :finished
-      }
+      %{state | hands: hands, scores: updated_scores, phase: :finished}
     else
       # Move to the next contract or dealer
       {next_dealer, next_contract} = Game.next_dealer_and_contract(state)
 
       # Deal the next contract
-      Game.deal_new_contract(%{state |
-        dealer_seat: next_dealer,
-        contract_index: next_contract,
-        scores: updated_scores
+      Game.deal_new_contract(%{
+        state
+        | dealer_seat: next_dealer,
+          contract_index: next_contract,
+          scores: updated_scores
       })
     end
   end

apps/lora/lib/lora/contracts/maximum.ex

@@ -6,7 +6,7 @@ defmodule Lora.Contracts.Maximum do
 
   @behaviour Lora.Contracts.ContractBehaviour
 
-  alias Lora.{Game, Score}
+  alias Lora.Score
   alias Lora.Contracts.TrickTaking
 
   @impl true

apps/lora/lib/lora/contracts/minimum.ex

@@ -6,7 +6,7 @@ defmodule Lora.Contracts.Minimum do
 
   @behaviour Lora.Contracts.ContractBehaviour
 
-  alias Lora.{Game, Score}
+  alias Lora.Score
   alias Lora.Contracts.TrickTaking
 
   @impl true

apps/lora/lib/lora/contracts/queens.ex

@@ -6,7 +6,7 @@ defmodule Lora.Contracts.Queens do
 
   @behaviour Lora.Contracts.ContractBehaviour
 
-  alias Lora.{Game, Score}
+  alias Lora.Score
   alias Lora.Contracts.TrickTaking
 
   @impl true

apps/lora/lib/lora/contracts/trick_taking.ex

@@ -14,7 +14,8 @@ defmodule Lora.Contracts.TrickTaking do
 
     case state.trick do
       # First card in trick can be anything
-      [] -> true
+      [] ->
+        true
 
       # Otherwise must follow suit if possible
       [{_, {led_suit, _}} | _] ->
@@ -40,10 +41,11 @@ defmodule Lora.Contracts.TrickTaking do
       winner_seat = Deck.trick_winner(updated_trick)
 
       # Add the cards from the trick to the winner's taken pile
-      taken = Map.update!(state.taken, winner_seat, fn taken_cards ->
-        trick_cards = Enum.map(updated_trick, fn {_seat, card} -> card end)
-        taken_cards ++ [trick_cards]
-      end)
+      taken =
+        Map.update!(state.taken, winner_seat, fn taken_cards ->
+          trick_cards = Enum.map(updated_trick, fn {_seat, card} -> card end)
+          taken_cards ++ [trick_cards]
+        end)
 
       # Check if the deal is over (all cards played)
       if Enum.all?(hands, fn {_seat, hand} -> hand == [] end) do
@@ -52,12 +54,7 @@ defmodule Lora.Contracts.TrickTaking do
         {:ok, deal_over_state}
       else
         # Continue with the next trick, winner leads
-        {:ok, %{state |
-          hands: hands,
-          trick: [],
-          taken: taken,
-          current_player: winner_seat
-        }}
+        {:ok, %{state | hands: hands, trick: [], taken: taken, current_player: winner_seat}}
       end
     else
       # Continue with the next player
@@ -81,21 +78,17 @@ defmodule Lora.Contracts.TrickTaking do
 
     # Check if the game is over
     if Game.game_over?(state) do
-      %{state |
-        hands: hands,
-        taken: taken,
-        scores: updated_scores,
-        phase: :finished
-      }
+      %{state | hands: hands, taken: taken, scores: updated_scores, phase: :finished}
     else
       # Move to the next contract or dealer
       {next_dealer, next_contract} = Game.next_dealer_and_contract(state)
 
       # Deal the next contract
-      Game.deal_new_contract(%{state |
-        dealer_seat: next_dealer,
-        contract_index: next_contract,
-        scores: updated_scores
+      Game.deal_new_contract(%{
+        state
+        | dealer_seat: next_dealer,
+          contract_index: next_contract,
+          scores: updated_scores
       })
     end
   end