Fix matches checker type

antonmedv · antonmedv · commit dd275daaefb6 · 2019-06-10T10:44:13.000+03:00
diff --git a/checker/checker.go b/checker/checker.go
@@ -235,7 +235,7 @@ func (v *visitor) MatchesNode(node *ast.MatchesNode) reflect.Type {
 	r := v.visit(node.Right)
 
 	if isString(l) && isString(r) {
-		return stringType
+		return boolType
 	}
 
 	panic(v.error(node, `invalid operation: matches (mismatched types %v and %v)`, l, r))
diff --git a/checker/checker_test.go b/checker/checker_test.go
@@ -175,6 +175,7 @@ func TestCheck(t *testing.T) {
 		"String in Foo",
 		"String matches 'ok'",
 		"String matches Any",
+		"(1 == 1) || (String matches Any)",
 		"String not in Foo2p",
 		"StringPtr == nil",
 		"Sub.Method(0) + String",

Original file line number	Diff line number	Diff line change
`@@ -235,7 +235,7 @@ func (v visitor) MatchesNode(node ast.MatchesNode) reflect.Type {`
`235`	`235`	`r := v.visit(node.Right)`
`236`	`236`
`237`	`237`	`if isString(l) && isString(r) {`
`238`		`- return stringType`
	`238`	`+ return boolType`
`239`	`239`	`}`
`240`	`240`
`241`	`241`	panic(v.error(node, `invalid operation: matches (mismatched types %v and %v)`, l, r))