perf: prevent internal throw when missing charset

closes #250

Author: jdspugh

HISTORY.md

@@ -15,6 +15,7 @@ unreleased
     - Use `http-errors` for standard emitted errors
     - deps: [email protected]
     - deps: [email protected]
+  * perf: prevent internal `throw` when missing charset
 
 1.17.2 / 2017-05-17
 ===================

lib/types/json.js

@@ -154,7 +154,7 @@ function firstchar (str) {
 
 function getCharset (req) {
   try {
-    return contentType.parse(req).parameters.charset.toLowerCase()
+    return (contentType.parse(req).parameters.charset || '').toLowerCase()
   } catch (e) {
     return undefined
   }

lib/types/text.js

@@ -101,7 +101,7 @@ function text (options) {
 
 function getCharset (req) {
   try {
-    return contentType.parse(req).parameters.charset.toLowerCase()
+    return (contentType.parse(req).parameters.charset || '').toLowerCase()
   } catch (e) {
     return undefined
   }

lib/types/urlencoded.js

@@ -171,7 +171,7 @@ function extendedparser (options) {
 
 function getCharset (req) {
   try {
-    return contentType.parse(req).parameters.charset.toLowerCase()
+    return (contentType.parse(req).parameters.charset || '').toLowerCase()
   } catch (e) {
     return undefined
   }