Are our tests reliable?

[bjohansebas]

We use supertest to run our tests in this module. While that tool does a great job, I'm not sure if we're making reliable tests, since Supertest also handles the body according to the content-type, which makes me question whether we're doing good tests or if in the future the tests will stop being reliable as we update that dependency.

Ref: forwardemail/superagent#1812

cc: @Phillip9587, @jonchurch, @wesleytodd, @UlisesGascon

[jonchurch]

Supertest only parses the body asserts against the parsed body if you assert against an object, but when doing a string assertion it compares against the raw res.text

https://github.com/ladjs/supertest/blob/2ae1c36f48fdc5a60e8239c2d69c47e169042829/lib/test.js#L186C5-L201C22

[jonchurch]

Which is to say, it's something important to think about. And we could explore lower level tests to ensure we are asserting against an unparsed response body.

Currently, we should be fine asserting against res.text by passing the body to expect as a string or regexp