Skip to content

Commit bfb559a

Browse files
committed
Warn if "referer" returns "referrer", or vice versa
1 parent 9b1c50f commit bfb559a

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

lib/request.js

+8-4
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,15 @@ req.header = function header(name) {
7474
var lc = name.toLowerCase();
7575

7676
switch (lc) {
77-
case 'referrer':
78-
deprecate('The "Referrer" header is non-standard, and special-casing for it will be dropped in future versions.');
7977
case 'referer':
80-
return this.headers.referrer
81-
|| this.headers.referer;
78+
case 'referrer':
79+
var isNameNonstandard = lc === 'referrer';
80+
var isHeaderNonstandard = !!this.headers.referrer;
81+
// Warn if "referer" returns "referrer", or vice versa.
82+
if (isNameNonstandard !== isHeaderNonstandard) {
83+
deprecate('The "Referrer" header is non-standard, and special-casing for it will be dropped in future versions.');
84+
}
85+
return this.headers.referrer || this.headers.referer;
8286
default:
8387
return this.headers[lc];
8488
}

0 commit comments

Comments
 (0)