✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

Technically speaking, people can still comment on closed PRs. I turned the PR into draft mode and added a comment to discuss on the issue page until further notice.

I know javascript has BigInt and JSON.stringify works with those no problems.

This isn't true. Neither JSON.parse nor JSON.stringify have BigInt support, which is a major source of frustration for me right now :)

> 123948124923742397432n
123948124923742397432n

> JSON.parse('{"x":123948124923742397432}')
{ x: 123948124923742400000 }

> JSON.stringify(123948124923742397432n)
Uncaught TypeError: Do not know how to serialize a BigInt
    at JSON.stringify (<anonymous>)

For now, we're using the json-bigint library in order to have BigInt support when serializing/deserializing JSON. That library has two options: either use the native BigInt or use the bignumber.js library. For other reasons that I won't go into, we're using the bignumber.js implementation, whose default JSON representation is a string

> const BigNumber = require('bignumber.js')
> let x = new BigNumber('123948124923742397432')
> JSON.stringify({ x })
'{"x":"123948124923742397432"}'

In order to get it to serialize as a number, you have to use json-bigint's function

> const JSONbig = require('json-bigint')
> JSONbig.stringify({ x })
'{"x":123948124923742397432}'

Uh oh!

Allow specifying JSON stringifier #4453

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions