fix(chatbot): detectChoiceOption exclut maintenant aussi les liens mailto: et tel:

Author: eyssette

app/js/core/chatbot/parsers/helpers/detectChoiceOption.mjs

@@ -1,10 +1,23 @@
+import { startsWithAnyOf } from "../../../../utils/strings.mjs";
+
 const regexOrderedList = /^\d{1,3}[.)]\s\[[^\]]+\]\(([^)]*)\)\s*$/;
 const regexOrderedListRandom = /^\d{1,3}\)/;
+const externalLinks = ["http", "mailto:", "tel:"];
+
+function isExternalLink(url) {
+	url = url.trim().toLowerCase();
+	return startsWithAnyOf(url, externalLinks);
+}
 
 export function detectChoiceOption(line) {
 	const match = line.match(regexOrderedList);
-	const isChoice =
-		match && !match[1].trim().toLowerCase().startsWith("http") ? true : false;
+	let isChoice = false;
+
+	if (match) {
+		const url = match[1];
+		isChoice = !isExternalLink(url);
+	}
+
 	return {
 		isChoice: isChoice,
 		isRandom: isChoice && regexOrderedListRandom.test(line),

tests/unit/core/chatbot/parsers/helpers/detectChoiceOption.spec.mjs

@@ -109,9 +109,15 @@ describe("detectChoiceOption", () => {
 		expect(result.isRandom).toBeFalse();
 	});
 
-	it("does not detect an ordered list with link to a URL starting with http… as a choice option", () => {
-		const result = detectChoiceOption("1. [text](https://example.com)");
-		expect(result.isChoice).toBeFalse();
-		expect(result.isRandom).toBeFalse();
+	it("does not detect an ordered list with link to an external URL, as a choice option", () => {
+		const result1 = detectChoiceOption("1. [text](https://example.com)");
+		expect(result1.isChoice).toBeFalse();
+		expect(result1.isRandom).toBeFalse();
+		const result2 = detectChoiceOption("1. [text](mailto:my@email.com)");
+		expect(result2.isChoice).toBeFalse();
+		expect(result2.isRandom).toBeFalse();
+		const result3 = detectChoiceOption("1. [text](tel:12312399R)");
+		expect(result3.isChoice).toBeFalse();
+		expect(result3.isRandom).toBeFalse();
 	});
 });