IBX-1201: Added handling of already generated aliases during subtree copying

For more details see https://issues.ibexa.co/browse/IBX-1201 and ezsystems/ezpublish-kernel#3127

* Added handling of already generated aliases during subtree copying

* Added integration test

Author: barw4

eZ/Publish/API/Repository/Tests/LocationServiceTest.php

@@ -21,6 +21,7 @@
 use eZ\Publish\API\Repository\Values\Content\Query;
 use eZ\Publish\API\Repository\Values\Content\Search\SearchHit;
 use eZ\Publish\API\Repository\Values\Content\URLAlias;
+use eZ\Publish\Core\Repository\Values\Content\ContentUpdateStruct;
 
 /**
  * Test case for operations in the LocationService using in memory storage.
@@ -2384,6 +2385,62 @@ public function testCopySubtreeWithAliases()
         $this->assertGeneratedAliases($urlAliasService, $expectedSubItemAliases);
     }
 
+    /**
+     * @covers \eZ\Publish\API\Repository\LocationService::copySubtree
+     */
+    public function testCopySubtreeWithTranslatedContent(): void
+    {
+        $repository = $this->getRepository();
+        $contentService = $repository->getContentService();
+        $contentTypeService = $repository->getContentTypeService();
+        $locationService = $repository->getLocationService();
+        $urlAliasService = $repository->getURLAliasService();
+
+        $mediaLocationId = $this->generateId('location', 43);
+        $filesLocationId = $this->generateId('location', 52);
+        $demoDesignLocationId = $this->generateId('location', 56);
+
+        $locationToCopy = $locationService->loadLocation($mediaLocationId);
+        $filesLocation = $locationService->loadLocation($filesLocationId);
+        $newParentLocation = $locationService->loadLocation($demoDesignLocationId);
+
+        // translating the 'middle' folder
+        $translatedDraft = $contentService->createContentDraft($filesLocation->contentInfo);
+        $contentUpdateStruct = new ContentUpdateStruct([
+            'initialLanguageCode' => 'ger-DE',
+            'fields' => $translatedDraft->getFields(),
+        ]);
+        $contentUpdateStruct->setField('short_name', 'FilesGER', 'ger-DE');
+        $translatedContent = $contentService->updateContent($translatedDraft->versionInfo, $contentUpdateStruct);
+        $contentService->publishVersion($translatedContent->versionInfo);
+
+        // creating additional content under translated folder
+        $contentType = $contentTypeService->loadContentTypeByIdentifier('folder');
+        $contentCreate = $contentService->newContentCreateStruct($contentType, 'eng-GB');
+        $contentCreate->setField('name', 'My folder');
+        $content = $contentService->createContent(
+            $contentCreate,
+            [new LocationCreateStruct(['parentLocationId' => $filesLocationId])]
+        );
+        $contentService->publishVersion($content->versionInfo);
+
+        $expectedSubItemAliases = [
+            '/Design/Plain-site/Media/Multimedia',
+            '/Design/Plain-site/Media/Images',
+            '/Design/Plain-site/Media/Files',
+            '/Design/Plain-site/Media/Files/my-folder',
+        ];
+
+        $this->assertAliasesBeforeCopy($urlAliasService, $expectedSubItemAliases);
+
+        $locationService->copySubtree(
+            $locationToCopy,
+            $newParentLocation
+        );
+
+        $this->assertGeneratedAliases($urlAliasService, $expectedSubItemAliases);
+    }
+
     /**
      * Asserts that given Content has default ContentStates.
      *

eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Handler.php

@@ -957,12 +957,18 @@ protected function getRealAliasId($locationId)
      * @param array $actionMap
      * @param mixed $oldParentAliasId
      * @param mixed $newParentAliasId
+     * @param string[] $alreadyGeneratedAliases
      */
-    protected function copySubtree($actionMap, $oldParentAliasId, $newParentAliasId)
+    protected function copySubtree($actionMap, $oldParentAliasId, $newParentAliasId, array $alreadyGeneratedAliases = []): array
     {
         $rows = $this->gateway->loadAutogeneratedEntries($oldParentAliasId);
         $newIdsMap = [];
         foreach ($rows as $row) {
+            $identifier = $row['parent'] . $row['text_md5'];
+            if (in_array($identifier, $alreadyGeneratedAliases)) {
+                continue;
+            }
+
             $oldParentAliasId = $row['id'];
 
             // Ensure that same action entries remain grouped by the same id
@@ -975,12 +981,20 @@ protected function copySubtree($actionMap, $oldParentAliasId, $newParentAliasId)
             $row['id'] = $row['link'] = $newIdsMap[$oldParentAliasId];
             $this->gateway->insertRow($row);
 
-            $this->copySubtree(
-                $actionMap,
-                $oldParentAliasId,
-                $row['id']
+            $alreadyGeneratedAliases[] = $identifier;
+
+            $alreadyGeneratedAliases = array_merge(
+                $alreadyGeneratedAliases,
+                $this->copySubtree(
+                    $actionMap,
+                    $oldParentAliasId,
+                    $row['id'],
+                    $alreadyGeneratedAliases
+                )
             );
         }
+
+        return $alreadyGeneratedAliases;
     }
 
     /**