Skip to content

Commit 13724e7

Browse files
authored
Merge pull request #53 from f-lab-edu/fix/error-code-base-interface
fix: ErrorCode 타입 불일치로 인한 컴파일 에러 수정
2 parents f0d63a2 + 6e13fb7 commit 13724e7

3 files changed

Lines changed: 18 additions & 7 deletions

File tree

module-api/src/test/java/com/whiskey/auth/controller/AuthControllerTest.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@
33
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
44
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;
55

6+
import com.whiskey.domain.auth.repository.RefreshTokenRepository;
67
import com.whiskey.domain.member.Member;
78
import com.whiskey.domain.member.enums.MemberStatus;
89
import com.whiskey.domain.member.repository.MemberRepository;
10+
import org.junit.jupiter.api.AfterEach;
911
import org.junit.jupiter.api.BeforeEach;
1012
import org.junit.jupiter.api.Test;
1113
import org.springframework.beans.factory.annotation.Autowired;
@@ -26,11 +28,15 @@ public class AuthControllerTest {
2628
@Autowired
2729
MemberRepository memberRepository;
2830

31+
@Autowired
32+
RefreshTokenRepository refreshTokenRepository;
33+
2934
@Autowired
3035
PasswordEncoder passwordEncoder;
3136

3237
@BeforeEach
3338
void setUp() {
39+
refreshTokenRepository.deleteAll();
3440
memberRepository.deleteAll();
3541
memberRepository.save(
3642
Member.builder()
@@ -56,4 +62,10 @@ void login_success_return_jwt_token() throws Exception {
5662
.andExpect(jsonPath("$.data.tokenType").value("Bearer"))
5763
.andExpect(jsonPath("$.data.memberInfo.email").value("tester22@example.com"));
5864
}
65+
66+
@AfterEach
67+
void clearDatabase() {
68+
refreshTokenRepository.deleteAll();
69+
memberRepository.deleteAll();
70+
}
5971
}

module-common/src/main/java/com/whiskey/exception/ErrorCode.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
@Getter
77
@Deprecated
8-
public enum ErrorCode {
8+
public enum ErrorCode implements BaseErrorCode {
99
VALIDATION_ERROR(HttpStatus.BAD_REQUEST, "유효성 검증에 실패했습니다."),
1010
INTERNAL_SERVER_ERROR(HttpStatus.INTERNAL_SERVER_ERROR, "서버에 문제가 발생했습니다. 잠시 후 다시 시도해주세요."),
1111
CONFLICT(HttpStatus.CONFLICT, "이미 처리된 요청입니다."),

module-common/src/main/java/com/whiskey/exception/GlobalExceptionHandler.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class GlobalExceptionHandler {
1717
@ExceptionHandler(Exception.class)
1818
public ResponseEntity<ApiResponse<Object>> handleCommonException(Exception exception) {
1919
log.error(exception.getMessage(), exception);
20-
ErrorCode errorCode = ErrorCode.INTERNAL_SERVER_ERROR;
20+
CommonErrorCode errorCode = CommonErrorCode.INTERNAL_SERVER_ERROR;
2121

2222
ApiResponse<Object> response = new ApiResponse<>(
2323
false,
@@ -32,7 +32,7 @@ public ResponseEntity<ApiResponse<Object>> handleCommonException(Exception excep
3232
@ExceptionHandler(BusinessException.class)
3333
public ResponseEntity<ApiResponse<Object>> handleBusinessException(BusinessException exception) {
3434
log.warn("code={}, message={}", exception.getErrorCode(), exception.getMessage());
35-
ErrorCode errorCode = exception.getErrorCode();
35+
BaseErrorCode errorCode = exception.getErrorCode();
3636
HttpStatus status = errorCode.getHttpStatus();
3737
String message = exception.getMessage();
3838
Object data = exception.getData();
@@ -50,7 +50,6 @@ public ResponseEntity<ApiResponse<Object>> handleBusinessException(BusinessExcep
5050
@ExceptionHandler(MethodArgumentNotValidException.class)
5151
public ResponseEntity<ApiResponse<Object>> handleMethodArgumentNotValidException(MethodArgumentNotValidException exception) {
5252
log.warn("Validation 실패: {}", exception.getBindingResult().getFieldErrors());
53-
ErrorCode errorCode = ErrorCode.VALIDATION_ERROR;
5453

5554
// 필드별 에러 메시지 추가
5655
Map<String, String> errorMessage = new HashMap<>();
@@ -60,11 +59,11 @@ public ResponseEntity<ApiResponse<Object>> handleMethodArgumentNotValidException
6059

6160
ApiResponse<Object> response = new ApiResponse<>(
6261
false,
63-
errorCode.name(),
64-
errorCode.getMessage(),
62+
HttpStatus.BAD_REQUEST.name(),
63+
"유효성 검증에 실패했습니다.",
6564
errorMessage
6665
);
6766

68-
return ResponseEntity.status(errorCode.getHttpStatus()).body(response);
67+
return ResponseEntity.status(HttpStatus.BAD_REQUEST).body(response);
6968
}
7069
}

0 commit comments

Comments
 (0)