feat: unify gcc binaries and sysroot (#183)

We already built gcc for the sysroot, so this commit switches the
binaries we use for the toolchain from buildroot to our own gcc builds.

Author: f0rmiga

.gitattributes

@@ -1 +1,4 @@
 docs/*.md linguist-generated=true
+sysroot/gcc-toolchain-aarch64.tar.xz filter=lfs diff=lfs merge=lfs -text
+sysroot/gcc-toolchain-armv7.tar.xz filter=lfs diff=lfs merge=lfs -text
+sysroot/gcc-toolchain-x86_64.tar.xz filter=lfs diff=lfs merge=lfs -text

.github/workflows/default.yaml

@@ -25,6 +25,8 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
+        with:
+          lfs: true
       - uses: bazel-contrib/setup-bazel@0.15.0
         with:
           bazelisk-cache: true
@@ -46,6 +48,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
+        with:
+          lfs: true
       - uses: bazel-contrib/setup-bazel@0.15.0
         with:
           bazelisk-cache: true
@@ -68,6 +72,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
+        with:
+          lfs: true
       - uses: bazel-contrib/setup-bazel@0.15.0
         with:
           bazelisk-cache: true
@@ -83,6 +89,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
+        with:
+          lfs: true
       - uses: bazel-contrib/setup-bazel@0.15.0
         with:
           bazelisk-cache: true
@@ -104,6 +112,8 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
+        with:
+          lfs: true
       - uses: bazel-contrib/setup-bazel@0.15.0
         with:
           bazelisk-cache: true

WORKSPACE

@@ -25,10 +25,6 @@ load("//:internal.bzl", "internal_dependencies")
 
 internal_dependencies()
 
-load("@rules_pkg//:deps.bzl", "rules_pkg_dependencies")
-
-rules_pkg_dependencies()
-
 load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
 
 bazel_skylib_workspace()
@@ -51,14 +47,25 @@ gcc_register_toolchain(
 
 gcc_register_toolchain(
     name = "gcc_toolchain_x86_64",
-    sysroot_variant = "x86_64-X11",
     target_arch = ARCHS.x86_64,
 )
 
 load("@rules_foreign_cc//foreign_cc:repositories.bzl", "rules_foreign_cc_dependencies")
 
 rules_foreign_cc_dependencies()
 
+load("@bazel_features//:deps.bzl", "bazel_features_deps")
+
+bazel_features_deps()
+
+load("@rules_python//python:repositories.bzl", "py_repositories")
+
+py_repositories()
+
 load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
 
 protobuf_deps()
+
+load("@rules_pkg//:deps.bzl", "rules_pkg_dependencies")
+
+rules_pkg_dependencies()

docs/defs.md

@@ -22,7 +22,6 @@ cc_library(
     srcs = ["plotlib/xwin11/Xwin2.c"],
     defines = ["UNDERSCORE", "NDEBUG"],
     linkopts = ["-lX11"],
-    features = ["no_libstdcxx"],
 )
 
 fortran_library(

examples/avl/avl.BUILD.bazel

@@ -31,7 +31,6 @@ build_test(
 cc_binary(
     name = "hello_world_c",
     srcs = ["main.c"],
-    features = ["no_libstdcxx"],
 )
 
 platform_transition_filegroup(

examples/hello_world_c/BUILD.bazel

@@ -18,6 +18,7 @@
 load("@aspect_bazel_lib//lib:transitions.bzl", "platform_transition_filegroup")
 load("@bazel_skylib//rules:build_test.bzl", "build_test")
 load("@rules_pkg//pkg:tar.bzl", "pkg_tar")
+load("//rules_cc:defs.bzl", "cc_binary", "cc_library", "cc_test")
 
 build_test(
     name = "hello_world_cpp_build_test",
@@ -70,7 +71,7 @@ cc_binary(
     name = "hello_world_cpp_static",
     srcs = ["main.cpp"],
     data = ["names.txt"],
-    features = ["static_libstdcxx"],
+    static_libstdcxx = True,
 )
 
 platform_transition_filegroup(

examples/hello_world_cpp/BUILD.bazel

@@ -15,7 +15,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-load("@rules_foreign_cc//foreign_cc:defs.bzl", "make")
+load("@rules_foreign_cc//foreign_cc:make.bzl", "make")
 
 _libs = [
     "liblapack.a",
@@ -43,7 +43,7 @@ make(
     lib_source = "@lapack//:srcs",
     out_static_libs = _libs,
     postfix_script = "\n".join([
-        "cp {0} $$INSTALLDIR$$/lib/{0}".format(lib)
+        "mv $$EXT_BUILD_ROOT/external/lapack/{0} $$INSTALLDIR/lib/{0}".format(lib)
         for lib in _libs
     ]),
     targets = [

examples/lapack/BUILD.bazel

@@ -17,7 +17,7 @@
 
 load("@aspect_bazel_lib//lib:transitions.bzl", "platform_transition_filegroup")
 load("@bazel_skylib//rules:build_test.bzl", "build_test")
-load("@rules_cc//cc:defs.bzl", "cc_proto_library")
+load("@com_google_protobuf//bazel:cc_proto_library.bzl", "cc_proto_library")
 load("@rules_pkg//pkg:tar.bzl", "pkg_tar")
 load("@rules_proto//proto:defs.bzl", "proto_library")
 

examples/protobuf/BUILD.bazel

@@ -24,8 +24,7 @@ load("//examples/lapack:patches.bzl", "LAPACK_PATCHES")
 
 # buildifier: disable=function-docstring
 def internal_dependencies():
-    maybe(
-        http_archive,
+    http_archive(
         name = "io_bazel_stardoc",
         sha256 = "dfbc364aaec143df5e6c52faf1f1166775a5b4408243f445f44b661cfdc3134f",
         urls = [
@@ -34,33 +33,36 @@ def internal_dependencies():
         ],
     )
 
-    maybe(
-        http_archive,
+    http_archive(
         name = "aspect_bazel_lib",
         sha256 = "a7e356f8a5cb8bf1e9be38c2c617ad22f5a1606792e839fc040971bdfbecf971",
         strip_prefix = "bazel-lib-1.40.2",
         url = "https://github.com/aspect-build/bazel-lib/archive/refs/tags/v1.40.2.tar.gz",
     )
 
-    maybe(
-        http_archive,
+    http_archive(
         name = "rules_foreign_cc",
-        sha256 = "2a4d07cd64b0719b39a7c12218a3e507672b82a97b98c6a89d38565894cf7c51",
-        strip_prefix = "rules_foreign_cc-0.9.0",
-        url = "https://github.com/bazelbuild/rules_foreign_cc/archive/0.9.0.tar.gz",
+        sha256 = "32759728913c376ba45b0116869b71b68b1c2ebf8f2bcf7b41222bc07b773d73",
+        strip_prefix = "rules_foreign_cc-0.15.1",
+        url = "https://github.com/bazel-contrib/rules_foreign_cc/releases/download/0.15.1/rules_foreign_cc-0.15.1.tar.gz",
     )
 
-    maybe(
-        http_archive,
+    http_archive(
+        name = "rules_python",
+        sha256 = "7b9039c31e909cf59eeaea8ccbdc54f09f7ebaeb9609b94371c7de45e802977c",
+        strip_prefix = "rules_python-1.5.0",
+        url = "https://github.com/bazel-contrib/rules_python/releases/download/1.5.0/rules_python-1.5.0.tar.gz",
+    )
+
+    http_archive(
         name = "openssl",
         build_file_content = _ALL_SRCS,
         sha256 = "40dceb51a4f6a5275bde0e6bf20ef4b91bfc32ed57c0552e2e8e15463372b17a",
         strip_prefix = "openssl-1.1.1n",
         url = "https://www.openssl.org/source/openssl-1.1.1n.tar.gz",
     )
 
-    maybe(
-        http_archive,
+    http_archive(
         name = "lapack",
         build_file_content = _ALL_SRCS,
         patch_cmds = LAPACK_PATCHES,
@@ -69,27 +71,24 @@ def internal_dependencies():
         url = "https://github.com/Reference-LAPACK/lapack/archive/refs/tags/v3.12.0.tar.gz",
     )
 
-    maybe(
-        http_archive,
+    http_archive(
         name = "avl",
         build_file = "@//:examples/avl/avl.BUILD.bazel",
         sha256 = "6d62e563578b79795a84958cfe4e221a4c9847fbeb4a821d45bc049934fc6a90",
         strip_prefix = "Avl",
         url = "https://web.mit.edu/drela/Public/web/avl/avl3.40b.tgz",
     )
 
-    maybe(
-        http_archive,
+    http_archive(
         name = "com_google_protobuf",
-        sha256 = "930c2c3b5ecc6c9c12615cf5ad93f1cd6e12d0aba862b572e076259970ac3a53",
-        strip_prefix = "protobuf-3.21.12",
-        urls = [
-            "https://github.com/protocolbuffers/protobuf/archive/v3.21.12.tar.gz",
-        ],
+        patches = ["//third_party/patches:com_google_protobuf.patch"],
+        patch_args = ["-p1"],
+        sha256 = "008a11cc56f9b96679b4c285fd05f46d317d685be3ab524b2a310be0fbad987e",
+        strip_prefix = "protobuf-29.3",
+        url = "https://github.com/protocolbuffers/protobuf/releases/download/v29.3/protobuf-29.3.tar.gz",
     )
 
-    maybe(
-        http_archive,
+    http_archive(
         name = "rules_pkg",
         sha256 = "8f9ee2dc10c1ae514ee599a8b42ed99fa262b757058f65ad3c384289ff70c4b8",
         urls = [