Type Error in Nested Donut Example

[curran]

I notice that in

packages/dev/src/examples/misc/nested-donut/basic-nested-donut/index.tsx

there is a type error:

Type 'number' is not assignable to type 'string'.

at this line:

<VisNestedDonut
  data={data}
  centralLabel='Central Label'
  centralSubLabel='Sub-label'
  layers={[
    (d: NestedDatum) => d.group,
    (d: NestedDatum) => d.subgroup,
    (d: NestedDatum) => d.value, // <--- Type error on this line here
  ]}

I'm using this as a reference for implementing a Treemap, and I'm skeptical if I should copy this API over to the new component, or if there is something wrong with the example implementation.

[curran]

Should it be like this maybe?

value={(d: NestedDatum) => d.value as number}
layers={[
  (d: NestedDatum) => d.group,
  (d: NestedDatum) => d.subgroup,
]}

[curran]

Nope, that's not right. Perhaps this would be the best fix:

<VisNestedDonut
  data={data}
  centralLabel='Central Label'
  centralSubLabel='Sub-label'
  layers={[
    (d: NestedDatum) => d.group,
    (d: NestedDatum) => d.subgroup,
    (d: NestedDatum) => d.value as string,
  ]}

since a datum looks like this

{group: 'C', subgroup: 'C2', value: 'C2a'}

[rokotyan]

Good observation