Skip to content

Commit cddb5aa

Browse files
TypeScript: made types a little more forgiving
1 parent 4f070f3 commit cddb5aa

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/collection/each.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
// @require core/each.ts
44

55
interface Cash {
6-
each ( callback: EachCallback<Ele> ): this;
6+
each ( callback: EachCallback<EleLoose> ): this;
77
}
88

9-
Cash.prototype.each = function ( this: Cash, callback: EachCallback<Ele> ) {
9+
Cash.prototype.each = function ( this: Cash, callback: EachCallback<EleLoose> ) {
1010
each ( this, callback );
1111
return this;
1212
};

src/collection/map.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
type MapCallback<T> = ( this: T, index: number, ele: T ) => Ele;
66

77
interface Cash {
8-
map ( callback: MapCallback<Ele> ): Cash;
8+
map ( callback: MapCallback<EleLoose> ): Cash;
99
}
1010

11-
Cash.prototype.map = function ( this: Cash, callback: MapCallback<Ele> ) {
11+
Cash.prototype.map = function ( this: Cash, callback: MapCallback<EleLoose> ) {
1212
return cash ( map.call ( this, ( ele: Ele, i: number ) => callback.call ( ele, i, ele ) ) );
1313
};

src/core/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22
interface Cash {
3-
[index: number]: EleAll,
3+
[index: number]: EleLoose,
44
length: number,
55
splice ( start: number, deleteCount?: number ): Ele[],
66
splice ( start: number, deleteCount: number, ...items: Ele[] ): Ele[]
@@ -14,7 +14,7 @@ type plainObject = { [index: string]: any };
1414
type falsy = undefined | null | false | 0 | '';
1515

1616
type Ele = Window | Document | HTMLElement | Element | Node;
17-
type EleAll = Window & Document & HTMLElement & Element & Node; //UGLY: Trick to remove some kind-of useless type errors //URL: https://github.com/kenwheeler/cash/issues/278
17+
type EleLoose = Window & Document & HTMLElement & Element & Node; //UGLY: Trick to remove some kind-of useless type errors //URL: https://github.com/kenwheeler/cash/issues/278
1818
type Selector = falsy | string | Function | HTMLCollection | NodeList | Ele | Ele[] | ArrayLike<Ele> | Cash;
1919
type Comparator = string | Ele | Cash | (( this: Ele, index: number, ele: Ele ) => boolean);
2020
type Context = Document | HTMLElement | Element;

0 commit comments

Comments
 (0)