$.fn.text: ensuring it reads text from every node in the collection, not just the first one, for better alignment with jQuery

Author: fabiospampinato

dist/cash.d.ts

@@ -52,10 +52,6 @@ interface Cash {
 interface Cash {
     empty(): this;
 }
-interface Cash {
-    text(): string;
-    text(text: string): this;
-}
 interface CashStatic {
     extend(): any;
     extend(deep: true, target: any, ...sources: any[]): any;
@@ -99,6 +95,10 @@ interface Cash {
 interface Cash {
     last(): Cash;
 }
+interface Cash {
+    text(): string;
+    text(text: string): this;
+}
 interface Cash {
     filter(comparator?: Comparator): Cash;
 }

dist/cash.esm.js

@@ -79,6 +79,9 @@ function isDocumentFragment(value) {
 function isElement(value) {
     return !!value && value.nodeType === 1;
 }
+function isText(value) {
+    return !!value && value.nodeType === 3;
+}
 function isBoolean(value) {
     return typeof value === 'boolean';
 }
@@ -143,17 +146,6 @@ fn.empty = function () {
         }
     });
 };
-function text(text) {
-    if (isUndefined(text))
-        return this[0] ? this[0].textContent : '';
-    return this.each((i, ele) => {
-        if (!isElement(ele))
-            return;
-        ele.textContent = text;
-    });
-}
-;
-fn.text = text;
 function extend(...sources) {
     const deep = isBoolean(sources[0]) ? sources.shift() : false;
     const target = sources.shift();
@@ -264,6 +256,17 @@ fn.first = function () {
 fn.last = function () {
     return this.eq(-1);
 };
+function text(text) {
+    if (isUndefined(text)) {
+        return this.get().map(ele => isElement(ele) || isText(ele) ? ele.textContent : '').join('');
+    }
+    return this.each((i, ele) => {
+        if (!isElement(ele))
+            return;
+        ele.textContent = text;
+    });
+}
+fn.text = text;
 // @require core/type_checking.ts
 // @require core/variables.ts
 function computeStyle(ele, prop, isVariable) {

dist/cash.js

@@ -82,6 +82,9 @@ function isDocumentFragment(value) {
 function isElement(value) {
     return !!value && value.nodeType === 1;
 }
+function isText(value) {
+    return !!value && value.nodeType === 3;
+}
 function isBoolean(value) {
     return typeof value === 'boolean';
 }
@@ -146,17 +149,6 @@ fn.empty = function () {
         }
     });
 };
-function text(text) {
-    if (isUndefined(text))
-        return this[0] ? this[0].textContent : '';
-    return this.each(function (i, ele) {
-        if (!isElement(ele))
-            return;
-        ele.textContent = text;
-    });
-}
-;
-fn.text = text;
 function extend() {
     var sources = [];
     for (var _i = 0; _i < arguments.length; _i++) {
@@ -271,6 +263,17 @@ fn.first = function () {
 fn.last = function () {
     return this.eq(-1);
 };
+function text(text) {
+    if (isUndefined(text)) {
+        return this.get().map(function (ele) { return isElement(ele) || isText(ele) ? ele.textContent : ''; }).join('');
+    }
+    return this.each(function (i, ele) {
+        if (!isElement(ele))
+            return;
+        ele.textContent = text;
+    });
+}
+fn.text = text;
 // @require core/type_checking.ts
 // @require core/variables.ts
 function computeStyle(ele, prop, isVariable) {

dist/cash.min.js

@@ -176,6 +176,12 @@ function isElement ( value: unknown ): value is HTMLElement {
 
 }
 
+function isText ( value: unknown ): value is Text {
+
+  return !!value && value.nodeType === 3;
+
+}
+
 function isBoolean ( value: unknown ): value is boolean {
 
   return typeof value === 'boolean';
@@ -319,34 +325,6 @@ fn.empty = function ( this: Cash ) {
 };
 
 
-// @require core/cash.ts
-// @require core/type_checking.ts
-// @require collection/each.ts
-
-interface Cash {
-  text (): string;
-  text ( text: string ): this;
-}
-
-function text ( this: Cash ): string;
-function text ( this: Cash, text: string ): Cash;
-function text ( this: Cash, text?: string ) {
-
-  if ( isUndefined ( text ) ) return this[0] ? this[0].textContent : '';
-
-  return this.each ( ( i, ele ) => {
-
-    if ( !isElement ( ele ) ) return;
-
-    ele.textContent = text
-
-  });
-
-};
-
-fn.text = text;
-
-
 // @require ./cash.ts
 // @require ./type_checking.ts
 
@@ -650,6 +628,39 @@ fn.last = function ( this: Cash ) {
 };
 
 
+// @require core/cash.ts
+// @require core/type_checking.ts
+// @require collection/each.ts
+// @require collection/get.ts
+
+interface Cash {
+  text (): string;
+  text ( text: string ): this;
+}
+
+function text ( this: Cash ): string;
+function text ( this: Cash, text: string ): Cash;
+function text ( this: Cash, text?: string ) {
+
+  if ( isUndefined ( text ) ) {
+
+    return this.get ().map ( ele => isElement ( ele ) || isText ( ele ) ? ele.textContent : '' ).join ( '' );
+
+  }
+
+  return this.each ( ( i, ele ) => {
+
+    if ( !isElement ( ele ) ) return;
+
+    ele.textContent = text;
+
+  });
+
+}
+
+fn.text = text;
+
+
 // @require core/type_checking.ts
 // @require core/variables.ts
 

dist/cash.ts

@@ -40,6 +40,12 @@ function isElement ( value: unknown ): value is HTMLElement {
 
 }
 
+function isText ( value: unknown ): value is Text {
+
+  return !!value && value.nodeType === 3;
+
+}
+
 function isBoolean ( value: unknown ): value is boolean {
 
   return typeof value === 'boolean';

src/core/type_checking.ts

@@ -2,6 +2,7 @@
 // @require core/cash.ts
 // @require core/type_checking.ts
 // @require collection/each.ts
+// @require collection/get.ts
 
 interface Cash {
   text (): string;
@@ -12,16 +13,20 @@ function text ( this: Cash ): string;
 function text ( this: Cash, text: string ): Cash;
 function text ( this: Cash, text?: string ) {
 
-  if ( isUndefined ( text ) ) return this[0] ? this[0].textContent : '';
+  if ( isUndefined ( text ) ) {
+
+    return this.get ().map ( ele => isElement ( ele ) || isText ( ele ) ? ele.textContent : '' ).join ( '' );
+
+  }
 
   return this.each ( ( i, ele ) => {
 
     if ( !isElement ( ele ) ) return;
 
-    ele.textContent = text
+    ele.textContent = text;
 
   });
 
-};
+}
 
 fn.text = text;

src/manipulation/text.ts

@@ -545,14 +545,22 @@ describe ( 'Manipulation', { beforeEach: getFixtureInit ( fixture ) }, function
 
   describe ( '$.fn.text', function ( it ) {
 
-    it ( 'gets the text', function ( t ) {
+    it ( 'gets the text from a single child', function ( t ) {
 
       var anchor = $('.anchor');
 
       t.is ( anchor.text (), 'content' );
 
     });
 
+    // it ( 'gets the text from a single child', function ( t ) {
+
+    //   var value = $('<p>1</p>\n<p>2</p>').text ();
+
+    //   t.is ( value, '1\n2 ' );
+
+    // });
+
     it ( 'sets html strings', function ( t ) {
 
       var anchor = $('.anchor');