Skip to content

Commit b93f248

Browse files
author
Maxime Mangel
committed
[All] Don't hide original error when failing to scan an assembly for plugin
Related to #3511
1 parent 0bb4ff2 commit b93f248

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

src/Fable.Cli/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1515
### Changed
1616

1717
* [Python] Remove `$` sign when reporting an error from `assert_equal` and `assert_not_equal` (#3878) (by @joprice)
18+
* [All] Don't hide original error when failing to scan an assembly for plugin (#3896) (by @MangelMaxime)
1819

1920
### Fixed
2021

src/Fable.Compiler/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## Unreleased
99

10+
### Changed
11+
12+
* [All] Don't hide original error when failing to scan an assembly for plugin (#3896) (by @MangelMaxime)
13+
1014
## 4.0.0-alpha-012 - 2024-06-17
1115

1216
### Fixed

src/Fable.Transforms/State.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ type Assemblies(getPlugin, fsharpAssemblies: FSharpAssembly list, addLog: Severi
3838
|> Seq.exists (fun attr ->
3939
attr.AttributeType.TryFullName = Some "Fable.ScanForPluginsAttribute"
4040
)
41-
with _ ->
41+
with error ->
4242
// To help identify problem, log information about the exception
4343
// but keep the process going to mimic previous Fable behavior
4444
// and because these exception seems harmless
4545
let errorMessage =
46-
$"Could not scan {path} for Fable plugins, skipping this assembly"
46+
$"Could not scan {path} for Fable plugins, skipping this assembly. Original error: {error.Message}"
4747

4848
addLog Severity.Info errorMessage
4949

0 commit comments

Comments
 (0)