build: add --temporal-only flag to the JavaScript test command

Author: MangelMaxime

src/Fable.Build/Main.fs

@@ -59,6 +59,8 @@ Available commands:
                                      (can be run in watch mode)
             --adaptive-only          Run only the tests for the adaptive version of Fable
                                      (can be run in watch mode)
+            --temporal-only          Run only the main tests, compiled with the Temporal
+                                     date/time representation (can be run in watch mode)
 
 
         Options for Rust:

src/Fable.Build/Test/JavaScript.fs

@@ -86,41 +86,20 @@ let private testAdaptive (isWatch: bool) =
     else
         Command.Fable(fableArgs, workingDirectory = destinationDir)
 
-// Second JS pass with the Temporal date/time representation enabled (--test:js-temporal).
-let private handleMainTestsTemporal () =
-    let folderName = "Main"
-    let sourceDir = Path.Resolve("tests", "Js", folderName)
-
-    let destinationDir = Path.Resolve("temp", "tests", "JavaScriptTemporal", folderName)
-
-    Directory.clean destinationDir
-
-    // Compile the whole Main project with the Temporal representation enabled
-    let fableArgs =
-        CmdLine.empty
-        |> CmdLine.appendRaw sourceDir
-        |> CmdLine.appendPrefix "--outDir" destinationDir
-        |> CmdLine.appendPrefix "--lang" "javascript"
-        |> CmdLine.appendPrefix "--exclude" "Fable.Core"
-        |> CmdLine.appendRaw "--noCache"
-        |> CmdLine.appendRaw "--test:js-temporal"
-
-    Command.Fable(fableArgs, workingDirectory = destinationDir)
+type private DateTimeRepresentation =
+    | JsDate
+    | Temporal
 
-    let nodeArgs =
-        CmdLine.empty
-        |> CmdLine.appendPrefix "--test-reporter" "spec"
-        |> CmdLine.appendPrefix "--test-timeout" "20000"
-        |> CmdLine.appendPrefix "--test" (destinationDir </> "Main.js")
-        |> CmdLine.toString
-
-    Command.Run("node", nodeArgs, workingDirectory = destinationDir)
-
-let private handleMainTests (isWatch: bool) (noDotnet: bool) =
+let private runMainTests (representation: DateTimeRepresentation) (isWatch: bool) (noDotnet: bool) =
     let folderName = "Main"
     let sourceDir = Path.Resolve("tests", "Js", folderName)
 
-    let destinationDir = Path.Resolve("temp", "tests", "JavaScript", folderName)
+    let outputFolder =
+        match representation with
+        | JsDate -> "JavaScript"
+        | Temporal -> "JavaScriptTemporal"
+
+    let destinationDir = Path.Resolve("temp", "tests", outputFolder, folderName)
 
     let testCommand =
         CmdLine.empty
@@ -141,6 +120,7 @@ let private handleMainTests (isWatch: bool) (noDotnet: bool) =
                 |> CmdLine.appendPrefix "--lang" "javascript"
                 |> CmdLine.appendPrefix "--exclude" "Fable.Core"
                 |> CmdLine.appendRaw "--noCache"
+                |> CmdLine.appendIf (representation = Temporal) "--test:js-temporal"
 
                 if isWatch then
                     CmdLine.empty
@@ -152,7 +132,6 @@ let private handleMainTests (isWatch: bool) (noDotnet: bool) =
             ]
 
     if isWatch then
-        // In watch mode, we only test the Main tests to not pollute the logs too much
         Async.Parallel
             [
                 if not noDotnet then
@@ -168,14 +147,21 @@ let private handleMainTests (isWatch: bool) (noDotnet: bool) =
             ]
         |> Async.RunSynchronously
         |> ignore
+    else
+        Command.Fable(fableArgs, workingDirectory = destinationDir)
+
+let private handleMainTests (isWatch: bool) (noDotnet: bool) =
+    if isWatch then
+        // In watch mode, we only test the Main tests to not pollute the logs too much
+        runMainTests JsDate isWatch noDotnet
     else
         Command.Run("dotnet", "run -c Release", workingDirectory = Path.Combine("tests", "Js", "Main"))
 
         // Test the Main tests against JavaScript
-        Command.Fable(fableArgs, workingDirectory = destinationDir)
+        runMainTests JsDate false noDotnet
 
-        // Re-run the date/time suites with the Temporal representation enabled
-        handleMainTestsTemporal ()
+        // Re-run them with the Temporal date/time representation enabled
+        runMainTests Temporal false noDotnet
 
         testReact false
         testAdaptive false
@@ -190,17 +176,23 @@ let handle (args: string list) =
     let isReactOnly = args |> List.contains "--react-only"
     let isStandaloneOnly = args |> List.contains "--standalone-only"
     let isAdaptiveOnly = args |> List.contains "--adaptive-only"
+    let isTemporalOnly = args |> List.contains "--temporal-only"
     let forceFableLibrary = args |> List.contains "--force-fable-library"
     let isWatch = args |> List.contains "--watch"
     let noDotnet = args |> List.contains "--no-dotnet"
 
-    match (isReactOnly, isStandaloneOnly, isAdaptiveOnly) with
-    | (true, true, _)
-    | (true, _, true)
-    | (_, true, true) ->
-        failwith "Cannot use '--react-only', '--standalone-only' and '--adaptive-only' at the same time"
+    let exclusiveArgs =
+        [
+            "--react-only", isReactOnly
+            "--standalone-only", isStandaloneOnly
+            "--adaptive-only", isAdaptiveOnly
+            "--temporal-only", isTemporalOnly
+        ]
+        |> List.filter snd
+        |> List.map (fun (name, _) -> $"'%s{name}'")
 
-    | _ -> ()
+    if exclusiveArgs.Length > 1 then
+        failwith $"""Cannot use %s{String.Join(", ", exclusiveArgs)} at the same time"""
 
     BuildFableLibraryJavaScript().Run(forceFableLibrary)
 
@@ -210,5 +202,7 @@ let handle (args: string list) =
         Standalone.handleStandaloneFast ()
     else if isAdaptiveOnly then
         testAdaptive isWatch
+    else if isTemporalOnly then
+        runMainTests Temporal isWatch noDotnet
     else
         handleMainTests isWatch noDotnet