Added test for removeElement.

Author: michaelkleinhenz

actions/rules/action_state_to_metastate.go

@@ -23,17 +23,6 @@ type ActionStateToMetaState struct {
 // make sure the rule is implementing the interface.
 var _ Action = ActionStateToMetaState{}
 
-/*
-func (act ActionStateToMetaState) containsUUID(s []uuid.UUID, e uuid.UUID) bool {
-	for _, a := range s {
-		if a == e {
-			return true
-		}
-	}
-	return false
-}
-*/
-
 func (act ActionStateToMetaState) contains(s []interface{}, e interface{}) bool {
 	for _, a := range s {
 		if a == e {
@@ -53,16 +42,6 @@ func (act ActionStateToMetaState) removeElement(s []interface{}, e interface{})
 		}
 	}
 	return s
-
-	/*
-		for idx, a := range s {
-			if a == e {
-				s = append(s[:idx], s[idx+1:]...)
-				// we don't return here as there may be multiple copies of e in s.
-			}
-		}
-		return s
-	*/
 }
 
 // difference returns the differences between two slices. It returns two slices containing

actions/rules/action_state_to_metastate_test.go

@@ -64,6 +64,53 @@ func (s *ActionStateToMetastateSuite) TestContainsElement() {
 	})
 }
 
+func (s *ActionStateToMetastateSuite) TestRemoveElement() {
+	s.T().Run("removing an existing element", func(t *testing.T) {
+		fxt := tf.NewTestFixture(t, s.DB, tf.CreateWorkItemEnvironment())
+		action := ActionStateToMetaState{
+			Db:     s.GormDB,
+			Ctx:    s.Ctx,
+			UserID: &fxt.Identities[0].ID,
+		}
+		// there is no other way of creating an []interface{}.
+		// but we have plenty of memory, so be it.
+		var a []interface{}
+		a = append(a, 0)
+		a = append(a, 1)
+		a = append(a, 2)
+		a = append(a, 3)
+		a = append(a, 2)
+		a = action.removeElement(a, 2)
+		require.Len(t, a, 3)
+		require.False(t, action.contains(a, 2))
+		a = action.removeElement(a, 1)
+		require.Len(t, a, 2)
+		require.False(t, action.contains(a, 1))
+	})
+	s.T().Run("removing a non-existing element", func(t *testing.T) {
+		fxt := tf.NewTestFixture(t, s.DB, tf.CreateWorkItemEnvironment())
+		action := ActionStateToMetaState{
+			Db:     s.GormDB,
+			Ctx:    s.Ctx,
+			UserID: &fxt.Identities[0].ID,
+		}
+		// there is no other way of creating an []interface{}.
+		// but we have plenty of memory, so be it.
+		var a []interface{}
+		a = append(a, 0)
+		a = append(a, 1)
+		a = append(a, 2)
+		a = append(a, 3)
+		a = append(a, 2)
+		a = action.removeElement(a, 4)
+		require.Len(t, a, 5)
+		require.True(t, action.contains(a, 0))
+		require.True(t, action.contains(a, 1))
+		require.True(t, action.contains(a, 2))
+		require.True(t, action.contains(a, 3))
+	})
+}
+
 func (s *ActionStateToMetastateSuite) TestActionExecution() {
 	// Note on the fixture: by default, the created board is attached to the type group
 	// with the same index. The columns on each board are as follows: