Merge pull request #14 from fabricekabongo/deepsource-autofix-9bad033b

refactor: fix check for empty string

Author: fabricekabongo

server/listener.go

@@ -2,12 +2,13 @@ package server
 
 import (
 	"bufio"
-	"github.com/fabricekabongo/loggerhead/query"
-	"github.com/prometheus/client_golang/prometheus"
-	"github.com/prometheus/client_golang/prometheus/promauto"
 	"log"
 	"net"
 	"time"
+
+	"github.com/fabricekabongo/loggerhead/query"
+	"github.com/prometheus/client_golang/prometheus"
+	"github.com/prometheus/client_golang/prometheus/promauto"
 )
 
 var (
@@ -117,7 +118,7 @@ func (h *Handler) handleConnection(conn net.Conn) error {
 		}
 		startOfEOF = time.Time{}
 		line := scanner.Text()
-		if len(line) == 0 {
+		if line == "" {
 			log.Println("Empty line received. Closing connection")
 			break
 		}

world/location.go

@@ -35,11 +35,11 @@ type Location struct {
 }
 
 func NewLocation(ns string, id string, lat float64, lon float64) (*Location, error) {
-	if len(id) == 0 {
+	if id == "" {
 		validationOps.Inc()
 		return nil, LocationErrorRequiredId
 	}
-	if len(ns) == 0 {
+	if ns == "" {
 		validationOps.Inc()
 		return nil, LocationErrorRequiredNamespace
 	}
@@ -60,11 +60,11 @@ func NewLocation(ns string, id string, lat float64, lon float64) (*Location, err
 }
 
 func (*Location) init(ns string, id string, lat float64, lon float64) (*Location, error) {
-	if len(id) == 0 {
+	if id == "" {
 		validationOps.Inc()
 		return nil, LocationErrorRequiredId
 	}
-	if len(ns) == 0 {
+	if ns == "" {
 		validationOps.Inc()
 		return nil, LocationErrorRequiredNamespace
 	}