fi deadlock on divide

fabricekabongo · fabricekabongo · commit 96bead854254 · 2025-11-16T01:55:08.000+04:00
diff --git a/world/tree.go b/world/tree.go
@@ -121,9 +121,6 @@ func (node *TreeNode) Delete(id string) {
 
 func (node *TreeNode) divide() {
 	defer treeDivision.Inc()
-	node.mu.Lock()
-	defer node.mu.Unlock()
-
 	if node.IsDivided {
 		return
 	}
@@ -207,9 +204,12 @@ func (node *TreeNode) ForceDivide(level int) {
 	if level == 0 {
 		return
 	}
+	node.mu.Lock()
+
 	if !node.IsDivided {
 		node.divide()
 	}
+	node.mu.Unlock()
 
 	level--
 

Original file line number	Diff line number	Diff line change
`@@ -121,9 +121,6 @@ func (node *TreeNode) Delete(id string) {`
`121`	`121`
`122`	`122`	`func (node *TreeNode) divide() {`
`123`	`123`	`defer treeDivision.Inc()`
`124`		`- node.mu.Lock()`
`125`		`- defer node.mu.Unlock()`
`126`		`-`
`127`	`124`	`if node.IsDivided {`
`128`	`125`	`return`
`129`	`126`	`}`
`@@ -207,9 +204,12 @@ func (node *TreeNode) ForceDivide(level int) {`
`207`	`204`	`if level == 0 {`
`208`	`205`	`return`
`209`	`206`	`}`
	`207`	`+ node.mu.Lock()`
	`208`	`+`
`210`	`209`	`if !node.IsDivided {`
`211`	`210`	`node.divide()`
`212`	`211`	`}`
	`212`	`+ node.mu.Unlock()`
`213`	`213`
`214`	`214`	`level--`
`215`	`215`