use panic so it can be caught earlier

Author: fabricekabongo

clustering/cluster.go

@@ -2,13 +2,14 @@ package clustering
 
 import (
 	"errors"
-	"github.com/fabricekabongo/loggerhead/config"
-	"github.com/fabricekabongo/loggerhead/query"
-	"github.com/hashicorp/memberlist"
 	"log"
 	"net"
 	"os"
 	"time"
+
+	"github.com/fabricekabongo/loggerhead/config"
+	"github.com/fabricekabongo/loggerhead/query"
+	"github.com/hashicorp/memberlist"
 )
 
 var (
@@ -65,7 +66,7 @@ func NewCluster(engine *query.Engine, config config.Config) (*Cluster, error) {
 
 	hostname, err := os.Hostname()
 	if err != nil {
-		log.Fatal("Failed to get hostname: ", err)
+		panic(err)
 	}
 
 	cfg := memberlist.DefaultLocalConfig()

world/namespace.go

@@ -26,9 +26,10 @@ func NewNamespace(name string) *Namespace {
 }
 
 func (n *Namespace) SaveLocation(id string, lat float64, lon float64) (*Location, error) {
-	n.mu.RLock()
+	n.mu.Lock()
+	defer n.mu.Unlock()
+
 	loc, ok := n.locations[id]
-	n.mu.RUnlock()
 
 	if ok {
 		err := loc.Update(lat, lon)
@@ -42,9 +43,7 @@ func (n *Namespace) SaveLocation(id string, lat float64, lon float64) (*Location
 		}
 		loc = newLoc
 
-		n.mu.Lock()
 		n.locations[id] = loc
-		n.mu.Unlock()
 	}
 
 	err := n.tree.Insert(loc)

world/world.go

@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"encoding/gob"
 	"errors"
-	"log"
 	"sync"
 )
 
@@ -97,7 +96,7 @@ func NewWorldFromBytes(buf []byte) *World {
 	err := dec.Decode(&w)
 
 	if err != nil {
-		log.Fatal(err)
+		panic(err)
 	}
 
 	return &w
@@ -111,7 +110,7 @@ func (m *World) Merge(w *World) {
 		for locId, loc := range n.locations {
 			err := m.Save(ns, locId, loc.Lat(), loc.Lon())
 			if err != nil {
-				log.Fatal("Error merging world: ", err)
+				panic(err)
 			}
 		}
 	}