|
| 1 | +use std::io::IsTerminal; |
| 2 | + |
1 | 3 | use anyhow::Result; |
2 | 4 | use fabro_types::settings::CliSettings; |
3 | 5 | use fabro_types::settings::cli::{CliLayer, OutputFormat}; |
@@ -57,9 +59,41 @@ pub(crate) async fn version_command( |
57 | 59 | } |
58 | 60 |
|
59 | 61 | print_text_output(&client, &server_info); |
| 62 | + warn_on_version_mismatch(&client, &server_info, printer); |
60 | 63 | Ok(()) |
61 | 64 | } |
62 | 65 |
|
| 66 | +fn warn_on_version_mismatch( |
| 67 | + client: &ClientVersionInfo, |
| 68 | + server: &ServerVersionInfo, |
| 69 | + printer: Printer, |
| 70 | +) { |
| 71 | + if !std::io::stderr().is_terminal() { |
| 72 | + return; |
| 73 | + } |
| 74 | + let Some(message) = version_mismatch_message(client.version, server) else { |
| 75 | + return; |
| 76 | + }; |
| 77 | + let yellow = console::Style::new().yellow(); |
| 78 | + fabro_util::printerr!(printer, "\n{} {}", yellow.apply_to("warning:"), message); |
| 79 | +} |
| 80 | + |
| 81 | +fn version_mismatch_message(client_version: &str, server: &ServerVersionInfo) -> Option<String> { |
| 82 | + let ServerVersionInfo::Success { |
| 83 | + version: Some(server_version), |
| 84 | + .. |
| 85 | + } = server |
| 86 | + else { |
| 87 | + return None; |
| 88 | + }; |
| 89 | + if server_version == client_version { |
| 90 | + return None; |
| 91 | + } |
| 92 | + Some(format!( |
| 93 | + "client version ({client_version}) does not match server version ({server_version})" |
| 94 | + )) |
| 95 | +} |
| 96 | + |
63 | 97 | struct ClientVersionInfo { |
64 | 98 | version: &'static str, |
65 | 99 | git_sha: &'static str, |
@@ -210,3 +244,53 @@ fn format_uptime(total_secs: i64) -> String { |
210 | 244 | format!("{seconds}s") |
211 | 245 | } |
212 | 246 | } |
| 247 | + |
| 248 | +#[cfg(test)] |
| 249 | +mod tests { |
| 250 | + use super::*; |
| 251 | + |
| 252 | + #[test] |
| 253 | + fn version_mismatch_message_covers_all_branches() { |
| 254 | + let matching = ServerVersionInfo::Success { |
| 255 | + address: "http://localhost".into(), |
| 256 | + version: Some("1.0.0".into()), |
| 257 | + git_sha: None, |
| 258 | + build_date: None, |
| 259 | + os: None, |
| 260 | + arch: None, |
| 261 | + uptime_secs: None, |
| 262 | + }; |
| 263 | + assert_eq!(version_mismatch_message("1.0.0", &matching), None); |
| 264 | + |
| 265 | + let mismatched = ServerVersionInfo::Success { |
| 266 | + address: "http://localhost".into(), |
| 267 | + version: Some("1.2.0".into()), |
| 268 | + git_sha: None, |
| 269 | + build_date: None, |
| 270 | + os: None, |
| 271 | + arch: None, |
| 272 | + uptime_secs: None, |
| 273 | + }; |
| 274 | + assert_eq!( |
| 275 | + version_mismatch_message("1.0.0", &mismatched).as_deref(), |
| 276 | + Some("client version (1.0.0) does not match server version (1.2.0)") |
| 277 | + ); |
| 278 | + |
| 279 | + let unknown = ServerVersionInfo::Success { |
| 280 | + address: "http://localhost".into(), |
| 281 | + version: None, |
| 282 | + git_sha: None, |
| 283 | + build_date: None, |
| 284 | + os: None, |
| 285 | + arch: None, |
| 286 | + uptime_secs: None, |
| 287 | + }; |
| 288 | + assert_eq!(version_mismatch_message("1.0.0", &unknown), None); |
| 289 | + |
| 290 | + let errored = ServerVersionInfo::Error { |
| 291 | + address: "http://localhost".into(), |
| 292 | + error: "oops".into(), |
| 293 | + }; |
| 294 | + assert_eq!(version_mismatch_message("1.0.0", &errored), None); |
| 295 | + } |
| 296 | +} |
0 commit comments