Skip to content

Unnecessary label content #55

Description

@oliverjam

The aria-labels on your submit buttons have a bit too much info in them.

For example "submit button for form to create new character"—the browser knows it's a submit button inside a form, so there's no need to duplicate this info.

It's also worth considering why you think non-sighted users need a different label in these cases. If "MAKE ME!" isn't enough info for a blind user, is it enough for a sighted one? You probably only need an alternative aria-label if the main one is purely visual (e.g. an icon).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions