pass constraints feasibility when the experiments or opt configs are not specified (#3244)

Summary:
Pull Request resolved: #3244

Changing status from fail to pass in the constraints feasibility health check when  experiment.optimization_config isn't specified.

Reviewed By: danielcohenlive

Differential Revision: D68279145

fbshipit-source-id: 0865dcbea6e48d248f10e2b57fc37dc340705848

Author: Jelena Markovic-Voronov

ax/analysis/healthcheck/constraints_feasibility.py

@@ -77,9 +77,14 @@ def compute(
             )
 
         if experiment.optimization_config is None:
-            raise UserInputError(
-                "ConstraintsFeasibilityAnalysis requires an Experiment with an "
-                "optimization config."
+            subtitle = "No optimization config is specified."
+            return HealthcheckAnalysisCard(
+                name="ConstraintsFeasibility",
+                title=f"Ax Constraints Feasibility {title_status}",
+                blob=json.dumps({"status": status}),
+                subtitle=subtitle,
+                df=df,
+                level=level,
             )
 
         if (

ax/analysis/healthcheck/tests/test_constraints_feasibility.py

@@ -5,6 +5,8 @@
 
 # pyre-strict
 
+import json
+
 import numpy as np
 import pandas as pd
 
@@ -13,6 +15,7 @@
     constraints_feasibility,
     ConstraintsFeasibilityAnalysis,
 )
+from ax.analysis.healthcheck.healthcheck_analysis import HealthcheckStatus
 from ax.core.batch_trial import BatchTrial
 from ax.core.data import Data
 from ax.core.experiment import Experiment
@@ -26,7 +29,10 @@
 from ax.modelbridge.model_spec import ModelSpec
 from ax.modelbridge.registry import Models
 from ax.utils.common.testutils import TestCase
-from ax.utils.testing.core_stubs import get_branin_experiment_with_multi_objective
+from ax.utils.testing.core_stubs import (
+    get_branin_experiment,
+    get_branin_experiment_with_multi_objective,
+)
 from ax.utils.testing.mock import mock_botorch_optimize
 from pyre_extensions import assert_is_instance, none_throws
 
@@ -196,6 +202,7 @@ def test_compute(self) -> None:
             "We suggest relaxing the constraint bounds for the constraints."
         )
         self.assertEqual(card.subtitle, subtitle)
+        self.assertEqual(json.loads(card.blob), {"status": HealthcheckStatus.WARNING})
 
         # experiment with no constraints
         experiment.optimization_config = OptimizationConfig(
@@ -210,3 +217,14 @@ def test_compute(self) -> None:
         self.assertEqual(card.title, "Ax Constraints Feasibility Success")
         self.assertEqual(card.level, AnalysisCardLevel.LOW)
         self.assertEqual(card.subtitle, "No constraints are specified.")
+        self.assertEqual(json.loads(card.blob), {"status": HealthcheckStatus.PASS})
+
+    def test_no_optimization_config(self) -> None:
+        experiment = get_branin_experiment(has_optimization_config=False)
+        cfa = ConstraintsFeasibilityAnalysis()
+        card = cfa.compute(experiment=experiment, generation_strategy=None)
+        self.assertEqual(card.name, "ConstraintsFeasibility")
+        self.assertEqual(card.title, "Ax Constraints Feasibility Success")
+        self.assertEqual(card.level, AnalysisCardLevel.LOW)
+        self.assertEqual(card.subtitle, "No optimization config is specified.")
+        self.assertEqual(json.loads(card.blob), {"status": HealthcheckStatus.PASS})