Include INFO status healthcheck cards in overview to save to db (#5022)

Summary:

In order for the INFO healthcheck cards to be shown in the Ax UI, they need to be saved to the db. This diff adds those cards to overview cards so they can be saved appropriately.

Differential Revision: D96492464

Author: shrutipatel31

ax/analysis/overview.py

@@ -20,7 +20,10 @@
     ConstraintsFeasibilityAnalysis,
 )
 from ax.analysis.healthcheck.early_stopping_healthcheck import EarlyStoppingAnalysis
-from ax.analysis.healthcheck.healthcheck_analysis import HealthcheckAnalysisCard
+from ax.analysis.healthcheck.healthcheck_analysis import (
+    HealthcheckAnalysisCard,
+    HealthcheckStatus,
+)
 from ax.analysis.healthcheck.metric_fetching_errors import MetricFetchingErrorsAnalysis
 from ax.analysis.healthcheck.predictable_metrics import PredictableMetricsAnalysis
 from ax.analysis.healthcheck.search_space_analysis import SearchSpaceAnalysis
@@ -265,10 +268,15 @@ def compute(
             if analyis is not None
         ]
 
-        non_passing_health_checks = [
+        user_facing_health_check_cards = [
             card
             for card in health_check_cards
-            if (isinstance(card, HealthcheckAnalysisCard) and not card.is_passing())
+            if (
+                isinstance(card, HealthcheckAnalysisCard)
+                and (
+                    not card.is_passing() or card.get_status() == HealthcheckStatus.INFO
+                )
+            )
             or isinstance(card, ErrorAnalysisCard)
         ]
 
@@ -277,9 +285,9 @@ def compute(
                 name="HealthchecksAnalysis",
                 title=HEALTH_CHECK_CARDGROUP_TITLE,
                 subtitle=HEALTH_CHECK_CARDGROUP_SUBTITLE,
-                children=non_passing_health_checks,
+                children=user_facing_health_check_cards,
             )
-            if len(non_passing_health_checks) > 0
+            if len(user_facing_health_check_cards) > 0
             else None
         )
 

ax/analysis/tests/test_overview.py

@@ -5,12 +5,16 @@
 
 # pyre-strict
 
-
 from datetime import datetime
+from unittest.mock import patch
 
 import pandas as pd
 from ax.adapter.base import Adapter
 from ax.adapter.registry import Generators
+from ax.analysis.healthcheck.healthcheck_analysis import (
+    create_healthcheck_analysis_card,
+    HealthcheckStatus,
+)
 from ax.analysis.insights import InsightsAnalysis
 from ax.analysis.overview import OverviewAnalysis
 from ax.analysis.plotly.arm_effects import ArmEffectsPlot
@@ -38,6 +42,7 @@
 from ax.utils.common.testutils import TestCase
 from ax.utils.testing.core_stubs import (
     get_data,
+    get_experiment,
     get_experiment_with_scalarized_objective_and_outcome_constraint,
     get_offline_experiments_subset,
     get_online_experiments,
@@ -447,3 +452,30 @@ def test_insights_analysis_single_parameter(self) -> None:
         # Check that none of the cards are error cards
         for card in all_cards:
             self.assertNotIsInstance(card, ErrorAnalysisCard)
+
+    def test_info_status_healthcheck_included_in_overview(self) -> None:
+        """Test that healthcheck cards with INFO status are included in the overview."""
+        info_card = create_healthcheck_analysis_card(
+            name="InfoHealthcheck",
+            title="Info Healthcheck",
+            subtitle="This is an info healthcheck",
+            df=pd.DataFrame(),
+            status=HealthcheckStatus.INFO,
+        )
+
+        with patch(
+            "ax.analysis.overview.ConstraintsFeasibilityAnalysis.compute_or_error_card",
+            return_value=info_card,
+        ):
+            overview_card = OverviewAnalysis().compute(
+                experiment=get_experiment(),
+                generation_strategy=None,
+            )
+
+            health_checks_group = next(
+                child
+                for child in overview_card.children
+                if child.name == "HealthchecksAnalysis"
+            )
+            health_check_names = [card.name for card in health_checks_group.flatten()]
+            self.assertIn("InfoHealthcheck", health_check_names)