Update ChoiceParameter encoder (#3510)

Summary:

`sort_values`  wasn't properly extracted in the encoder. This leads to a bunch of log spew when decoding a choice parameter.

Differential Revision: D71261719

Author: David Eriksson

ax/storage/json_store/encoders.py

@@ -189,6 +189,7 @@ def choice_parameter_to_dict(parameter: ChoiceParameter) -> dict[str, Any]:
         "is_fidelity": parameter.is_fidelity,
         "target_value": parameter.target_value,
         "dependents": parameter.dependents if parameter.is_hierarchical else None,
+        "sort_values": parameter.sort_values,
     }
 
 

ax/storage/json_store/tests/test_json_store.py

@@ -117,6 +117,7 @@
     get_scheduler_options_batch_trial,
     get_search_space,
     get_sebo_acquisition_class,
+    get_sorted_choice_parameter,
     get_sum_constraint1,
     get_sum_constraint2,
     get_surrogate,
@@ -172,6 +173,7 @@
     ("BraninMetric", get_branin_metric),
     ("ChainedInputTransform", get_chained_input_transform),
     ("ChoiceParameter", get_choice_parameter),
+    ("ChoiceParameter", get_sorted_choice_parameter),
     # testing with non-default argument
     ("DataLoaderConfig", partial(DataLoaderConfig, fit_out_of_design=True)),
     ("Experiment", get_experiment_with_batch_and_single_trial),

ax/utils/testing/core_stubs.py

@@ -1488,6 +1488,16 @@ def get_ordered_choice_parameter() -> ChoiceParameter:
     )
 
 
+def get_sorted_choice_parameter() -> ChoiceParameter:
+    return ChoiceParameter(
+        name="y",
+        parameter_type=ParameterType.STRING,
+        values=["2", "1", "3"],
+        is_ordered=True,
+        sort_values=True,
+    )
+
+
 def get_task_choice_parameter() -> ChoiceParameter:
     return ChoiceParameter(
         name="y",