Skip to content

Commit 607305c

Browse files
saitcakmakmeta-codesync[bot]
authored andcommitted
Remove AxClient._get_pending_observation_features (#4872)
Summary: Pull Request resolved: #4872 Removes unused private methods, discovered while checking if T189551835 is still relevant. Reviewed By: Cesar-Cardoso Differential Revision: D92721417 fbshipit-source-id: ac52297cf01e05c5370808515b8ae4b2ebab2235
1 parent dc12eec commit 607305c

1 file changed

Lines changed: 0 additions & 17 deletions

File tree

ax/service/ax_client.py

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
from ax.core.trial import Trial
3232
from ax.core.trial_status import TrialStatus
3333
from ax.core.types import TEvaluationOutcome, TParameterization, TParamValue
34-
from ax.core.utils import get_pending_observation_features_based_on_trial_status
3534
from ax.early_stopping.strategies import BaseEarlyStoppingStrategy
3635
from ax.early_stopping.utils import estimate_early_stopping_savings
3736
from ax.exceptions.constants import CHOLESKY_ERROR_ANNOTATION
@@ -1677,22 +1676,6 @@ def _validate_all_required_metrics_present(
16771676
missing_metrics = required_metrics - provided_metrics
16781677
return not missing_metrics
16791678

1680-
@classmethod
1681-
def _get_pending_observation_features(
1682-
cls,
1683-
experiment: Experiment,
1684-
) -> dict[str, list[ObservationFeatures]] | None:
1685-
"""Extract pending points for the given experiment.
1686-
1687-
NOTE: With one-arm `Trial`-s, we use a more performant
1688-
``get_pending_observation_features_based_on_trial_status`` utility instead
1689-
of ``get_pending_observation_features``, since we can determine whether a point
1690-
is pending based on the status of the corresponding trial.
1691-
"""
1692-
return get_pending_observation_features_based_on_trial_status(
1693-
experiment=experiment
1694-
)
1695-
16961679
# ------------------------------ Validators. -------------------------------
16971680

16981681
def _validate_early_stopping_strategy(

0 commit comments

Comments
 (0)