Commit 77dd69f
Override is_available_while_running on DerivedMetric (#5028)
Summary:
Pull Request resolved: #5028
`DerivedMetric.is_available_while_running()` currently inherits the base
`Metric` default of `False`. This causes `fetch_data_prefer_lookup` to
skip derived metrics for running trials -- it returns cached data (which
is empty) instead of computing from freshly-fetched base data.
Override the classmethod to return `True` so derived metrics always
attempt to compute. If base data isn't available, `fetch_trial_data`
returns empty data which is handled gracefully downstream.
Reviewed By: lena-kashtelyan
Differential Revision: D96558279
fbshipit-source-id: 5ae71ecf24aa01f7a11a294ab3579e44f092d1fd1 parent 1dda964 commit 77dd69f
1 file changed
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
110 | 120 | | |
111 | 121 | | |
112 | 122 | | |
| |||
0 commit comments