Remove generated_points argument to RandomGenerator (#5186)

Summary:
Pull Request resolved: #5186

**Context**: This was deprecated in Ax 1.0.0 and has not done anything since then.

**This PR**:
* Removes `generated_points` argument to `RandomGenerator`
* Removes places where this is passed (which would have been recursively triggering the warning)

Reviewed By: saitcakmak

Differential Revision: D101824526

fbshipit-source-id: 61d44c0efc37a2443f0cf7afacd78a3ede48c1cc

Author: esantorella

ax/adapter/tests/test_registry.py

@@ -177,7 +177,6 @@ def test_view_defaults(self) -> None:
                     "deduplicate": True,
                     "init_position": 0,
                     "scramble": True,
-                    "generated_points": None,
                     "fallback_to_sample_polytope": False,
                     "polytope_sampler_kwargs": None,
                 },

ax/generation_strategy/tests/test_generation_strategy.py

@@ -673,7 +673,6 @@ def test_sobol_MBM_strategy(self) -> None:
                         "scramble": True,
                         "fallback_to_sample_polytope": False,
                         "polytope_sampler_kwargs": None,
-                        "generated_points": None,
                     },
                 )
                 self.assertEqual(
@@ -1631,7 +1630,6 @@ def test_gs_with_generation_nodes(self) -> None:
                         "scramble": True,
                         "fallback_to_sample_polytope": False,
                         "polytope_sampler_kwargs": None,
-                        "generated_points": None,
                     },
                 )
                 self.assertEqual(

ax/generators/random/base.py

@@ -6,7 +6,6 @@
 
 # pyre-strict
 
-import warnings
 from collections.abc import Callable
 from logging import Logger
 from typing import Any
@@ -57,9 +56,6 @@ class RandomGenerator(Generator):
             of samples to fast-forward before generating new samples.
             Used to ensure that the re-loaded generator will continue generating
             from the same sequence rather than starting from scratch.
-        generated_points: A set of previously generated points to use
-            for deduplication. These should be provided in the raw transformed
-            space the model operates in.
         fallback_to_sample_polytope: If True, when rejection sampling fails,
             we fall back to the HitAndRunPolytopeSampler.
     """
@@ -69,7 +65,6 @@ def __init__(
         deduplicate: bool = True,
         seed: int | None = None,
         init_position: int = 0,
-        generated_points: npt.NDArray | None = None,
         fallback_to_sample_polytope: bool = False,
         polytope_sampler_kwargs: dict[str, Any] | None = None,
     ) -> None:
@@ -86,15 +81,6 @@ def __init__(
         self.polytope_sampler_kwargs: dict[str, Any] = polytope_sampler_kwargs or {}
         self._bounds: npt.NDArray = np.empty((0, 2))
         self.attempted_draws: int = 0
-        if generated_points is not None:
-            # generated_points was deprecated in Ax 1.0.0, so it can now be reaped.
-            warnings.warn(
-                "The `generated_points` argument is deprecated and will be removed "
-                "in a future version of Ax. It is being ignored in favor of "
-                "extracting the generated points directly from the experiment.",
-                DeprecationWarning,
-                stacklevel=2,
-            )
 
     @property
     def can_predict(self) -> bool:

ax/generators/random/sobol.py

@@ -38,15 +38,13 @@ def __init__(
         seed: int | None = None,
         init_position: int = 0,
         scramble: bool = True,
-        generated_points: npt.NDArray | None = None,
         fallback_to_sample_polytope: bool = False,
         polytope_sampler_kwargs: dict[str, Any] | None = None,
     ) -> None:
         super().__init__(
             deduplicate=deduplicate,
             seed=seed,
             init_position=init_position,
-            generated_points=generated_points,
             fallback_to_sample_polytope=fallback_to_sample_polytope,
             polytope_sampler_kwargs=polytope_sampler_kwargs,
         )

ax/generators/random/uniform.py

@@ -26,14 +26,12 @@ def __init__(
         deduplicate: bool = True,
         seed: int | None = None,
         init_position: int = 0,
-        generated_points: npt.NDArray | None = None,
         fallback_to_sample_polytope: bool = False,
     ) -> None:
         super().__init__(
             deduplicate=deduplicate,
             seed=seed,
             init_position=init_position,
-            generated_points=generated_points,
             fallback_to_sample_polytope=fallback_to_sample_polytope,
         )
         self._rs = np.random.RandomState(seed=self.seed)

ax/storage/json_store/decoder.py

@@ -140,6 +140,7 @@ def _raise_on_legacy_callable_refs(kwarg_dict: dict[str, Any]) -> dict[str, Any]
     "torch_dtype",
     "status_quo_name",
     "status_quo_features",
+    "generated_points",
 )
 
 # Deprecated node input constructors, removed from GNodes.

ax/storage/json_store/tests/test_json_store.py

@@ -1261,6 +1261,7 @@ def test_generator_run_backwards_compatibility(self) -> None:
                 "deduplicate": False,
                 "seed": None,
                 "torch_dtype": None,
+                "generated_points": None,
             },
             "bridge_kwargs": {
                 "transforms": {},

ax/storage/sqa_store/tests/test_sqa_store.py

@@ -833,13 +833,13 @@ def test_experiment_save_and_load_reduced_state(
             # 3. Try case with model state and search space + opt.config on a
             # generator run in the experiment.
             gr = Generators.SOBOL(experiment=exp).gen(1)
-            # Expecting model kwargs to have 7 fields (seed, deduplicate, init_position,
-            # scramble, generated_points, fallback_to_sample_polytope,
+            # Expecting model kwargs to have 6 fields (seed, deduplicate, init_position,
+            # scramble, fallback_to_sample_polytope,
             # polytope_sampler_kwargs)
             # and the rest of model-state info on generator run to have values too.
             generator_kwargs = gr._generator_kwargs
             self.assertIsNotNone(generator_kwargs)
-            self.assertEqual(len(generator_kwargs), 7)
+            self.assertEqual(len(generator_kwargs), 6)
             adapter_kwargs = gr._adapter_kwargs
             self.assertIsNotNone(adapter_kwargs)
             self.assertEqual(len(adapter_kwargs), 6)
@@ -1896,8 +1896,6 @@ def test_parameter_constraint_validation(self) -> None:
         sqa_parameter_constraint = SQAParameterConstraint(
             bound=Decimal(0),
             constraint_dict={},
-            # pyre-fixme[6]: For 3rd param expected `IntEnum` but got
-            #  `ParameterConstraintType`.
             type=ParameterConstraintType.LINEAR,
         )
         with self.assertRaises(ValueError):
@@ -1915,8 +1913,6 @@ def test_parameter_constraint_validation(self) -> None:
         sqa_parameter_constraint = SQAParameterConstraint(
             bound=Decimal(0),
             constraint_dict={},
-            # pyre-fixme[6]: For 3rd param expected `IntEnum` but got
-            #  `ParameterConstraintType`.
             type=ParameterConstraintType.LINEAR,
             generator_run_id=0,
         )
@@ -1929,8 +1925,6 @@ def test_parameter_constraint_validation(self) -> None:
 
     def test_decode_order_parameter_constraint_failure(self) -> None:
         sqa_parameter = SQAParameterConstraint(
-            # pyre-fixme[6]: For 1st param expected `IntEnum` but got
-            #  `ParameterConstraintType`.
             type=ParameterConstraintType.ORDER,
             constraint_dict={},
             bound=Decimal(0),
@@ -1942,8 +1936,6 @@ def test_decode_order_parameter_constraint_failure(self) -> None:
 
     def test_decode_sum_parameter_constraint_failure(self) -> None:
         sqa_parameter = SQAParameterConstraint(
-            # pyre-fixme[6]: For 1st param expected `IntEnum` but got
-            #  `ParameterConstraintType`.
             type=ParameterConstraintType.SUM,
             constraint_dict={},
             bound=Decimal(0),