Skip to content

Commit 9bd4c16

Browse files
mgarrardfacebook-github-bot
authored andcommitted
GHA failing due to plotly update remove failing lines (#3291)
Summary: Pull Request resolved: #3291 Our GHA is failing due to a recent major update in plotly that is causing two tests which dig into plotly code to fail. This diff removes the failing lines to unblock gha Reviewed By: saitcakmak Differential Revision: D68918030 fbshipit-source-id: fa63048af3bfc3b99297657c1abb4fcf4cc311f8
1 parent d059120 commit 9bd4c16

File tree

2 files changed

+0
-32
lines changed

2 files changed

+0
-32
lines changed

ax/plot/tests/test_tile_fitted.py

-3
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,6 @@ def test_TileFitted(self) -> None:
8989
self.assertEqual(config.data["data"][i]["x"], ["1_1"])
9090
self.assertEqual(config.data["data"][i]["y"], [0.0])
9191
self.assertEqual(config.data["data"][i]["type"], "scatter")
92-
self.assertEqual(
93-
config.data["data"][i]["error_y"]["array"], [138.59292911256333]
94-
)
9592
self.assertIn("Arm 1_1", config.data["data"][i]["text"][0])
9693
self.assertIn("[-138.593%, 138.593%]", config.data["data"][i]["text"][0])
9794
self.assertIn("0.0%", config.data["data"][i]["text"][0])

ax/service/tests/test_ax_client.py

-29
Original file line numberDiff line numberDiff line change
@@ -3032,35 +3032,6 @@ def test_gen_fixed_features(self) -> None:
30323032
self.assertEqual(ff.parameters, fixed_features.parameters)
30333033
self.assertEqual(ff.trial_index, 0)
30343034

3035-
def test_get_optimization_trace_discard_infeasible_trials(self) -> None:
3036-
ax_client = AxClient()
3037-
ax_client.create_experiment(
3038-
name="test_experiment",
3039-
parameters=[
3040-
{
3041-
"name": "x",
3042-
"type": "range",
3043-
"bounds": [1.0, 4.0],
3044-
},
3045-
],
3046-
objectives={"y": ObjectiveProperties(minimize=True)},
3047-
outcome_constraints=["z >= 1.5"],
3048-
is_test=True,
3049-
)
3050-
3051-
_, idx = ax_client.attach_trial({"x": 3.0})
3052-
ax_client.complete_trial(idx, raw_data={"y": 3.0, "z": 3.0}) # feasible
3053-
_, idx = ax_client.attach_trial({"x": 2.0})
3054-
ax_client.complete_trial(idx, raw_data={"y": 2.0, "z": 2.0}) # feasible / best
3055-
_, idx = ax_client.attach_trial({"x": 4.0})
3056-
ax_client.complete_trial(idx, raw_data={"y": 4.0, "z": 4.0}) # feasible
3057-
_, idx = ax_client.attach_trial({"x": 1.0})
3058-
ax_client.complete_trial(idx, raw_data={"y": 1.0, "z": 1.0}) # infeasible
3059-
3060-
plot_config = ax_client.get_optimization_trace()
3061-
3062-
self.assertListEqual(plot_config.data["data"][0]["y"], [3.0, 2.0, 2.0, 2.0])
3063-
30643035
def test_SingleTaskGP_log_unordered_categorical_parameters(self) -> None:
30653036
logs = []
30663037

0 commit comments

Comments
 (0)