Fix SearchSpaceAnalysis crash on non-numeric ordered choice parameters#4991
Closed
eonofrey wants to merge 1 commit into
Closed
Fix SearchSpaceAnalysis crash on non-numeric ordered choice parameters#4991eonofrey wants to merge 1 commit into
eonofrey wants to merge 1 commit into
Conversation
Summary: `search_space_boundary_proportions` assumed all ordered `ChoiceParameter` values are numeric (`int | float`), but some expeirments have ordered string values (somehow?). When this happens, the SearchSpaceBoundary check breaks ([example](https://www.internalfb.com/ax/experiment/p_wyt_directional_v7_ax/experiment)). This diff adds a check that all values are numeric before entering that branch, so non-numeric ordered choice parameters are skipped like unordered ones. Reviewed By: ItsMrLin Differential Revision: D94979372
meta-cla
Bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4991 +/- ##
==========================================
- Coverage 96.83% 96.83% -0.01%
==========================================
Files 599 599
Lines 64584 64590 +6
==========================================
+ Hits 62540 62543 +3
- Misses 2044 2047 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in eb264f1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
search_space_boundary_proportionsassumed all orderedChoiceParametervaluesare numeric (
int | float), but some expeirments have ordered string values (somehow?). When this happens, the SearchSpaceBoundary check breaks (example).This diff adds a check that all values are numeric before entering that branch,
so non-numeric ordered choice parameters are skipped like unordered ones.
Reviewed By: ItsMrLin
Differential Revision: D94979372