Commit 0ab0189
Fix call chaining CacheBase and CacheAllocator to set EventTracker
Summary:
#### [Cachelib] Fix call chaining CacheBase and CacheAllocator to set EventTracker
**Cache.h Changes:**
* The function `setEventTracker` has been made virtual.
* The functions `setEventTrackerSamplingRate` and `disableEventTracker` have been removed from the `Cache` class. This will be handled by Luna.
**Cache.cpp Changes:**
* The implementation of `getEventTracker` remains unchanged.
* The implementation of `setEventTrackerSamplingRate` has been removed. This will be handled by Luna.
**Impact:**
This diff aims to fix the call chaining between `CacheBase` and `CacheAllocator` to set the `EventTracker`. The changes make the `setEventTracker` function virtual, allowing for proper overriding in derived classes. Additionally, `setEventTrackerSamplingRate` and `disableEventTracker` are not needed as changing and disabling EventTracker will be handled by Luna.
Reviewed By: rlyerly
Differential Revision: D92208056
fbshipit-source-id: 88f0c252345c2e980093e77e67b702299cb29f1f1 parent 2057e42 commit 0ab0189
3 files changed
Lines changed: 2 additions & 28 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
634 | 634 | | |
635 | 635 | | |
636 | 636 | | |
637 | | - | |
638 | | - | |
639 | | - | |
640 | | - | |
641 | | - | |
642 | | - | |
643 | | - | |
644 | | - | |
645 | | - | |
646 | | - | |
647 | | - | |
648 | | - | |
649 | | - | |
650 | | - | |
651 | | - | |
652 | | - | |
653 | | - | |
654 | | - | |
655 | | - | |
656 | | - | |
657 | | - | |
658 | | - | |
659 | | - | |
660 | | - | |
661 | 637 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
234 | | - | |
235 | | - | |
236 | | - | |
| 234 | + | |
237 | 235 | | |
238 | 236 | | |
239 | 237 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1255 | 1255 | | |
1256 | 1256 | | |
1257 | 1257 | | |
1258 | | - | |
| 1258 | + | |
1259 | 1259 | | |
1260 | 1260 | | |
1261 | 1261 | | |
| |||
0 commit comments