deprecated objcache: fix expiry check in deprecated persistence to use <=

Summary:
- Root cause: time() has 1s resolution. With ttlShort=1s and sleep 2s, when loop crosses second boundary some odds get expiry = T+2, recovery happens exactly at T+2. Old check expiry < now treats equality as valid, so expired items are recovered -> ASSERT_FALSE fails.
- New objcache2 already uses <=. Changing to <= makes expiry inclusive, so sleep 2s always expires short items even with truncation.

Reviewed By: AlnisM

Differential Revision: D113410019

fbshipit-source-id: 32c057d7efd758264b0a80de22562168e03cbc67

Author: rlyerly

cachelib/experimental/deprecated_objcache/Persistence.h

@@ -227,7 +227,7 @@ class RestorerWorker : public PeriodicWorker {
   void setBreakOut() { breakOut_ = true; }
 
   bool isExpired(uint32_t expiryTime, uint32_t nowTime) {
-    if (expiryTime != 0 && expiryTime < nowTime) {
+    if (expiryTime != 0 && expiryTime <= nowTime) {
       return true;
     }