Add BigHash lookup and insert latency counters

Summary: We already export latency metrics for block cache. This diff adds insert and lookup latency for big hash.

Reviewed By: rlyerly

Differential Revision: D113406659

fbshipit-source-id: 52cb42fa0914f4012a2a50862688fc8b6f1d812c

Author: AlnisM

cachelib/allocator/nvmcache/tests/NvmCacheTests.cpp

@@ -1824,6 +1824,36 @@ TEST_F(NvmCacheTest, NavyStats) {
   EXPECT_TRUE(cs("navy_bh_item_lifetime_secs_p9999"));
   EXPECT_TRUE(cs("navy_bh_item_lifetime_secs_p99999"));
   EXPECT_TRUE(cs("navy_bh_item_lifetime_secs_p999999"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_avg"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_min"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_max"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_p5"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_p10"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_p25"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_p50"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_p75"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_p90"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_p95"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_p99"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_p999"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_p9999"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_p99999"));
+  EXPECT_TRUE(cs("navy_bh_lookup_latency_us_p999999"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_avg"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_min"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_max"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_p5"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_p10"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_p25"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_p50"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_p75"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_p90"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_p95"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_p99"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_p999"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_p9999"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_p99999"));
+  EXPECT_TRUE(cs("navy_bh_insert_latency_us_p999999"));
   EXPECT_TRUE(cs("navy_bh_disabled_bucket_lookup"));
   EXPECT_TRUE(cs("navy_bh_disabled_bucket_insert"));
   EXPECT_TRUE(cs("navy_bh_disabled_bucket_remove"));

cachelib/navy/bighash/BigHash.cpp

@@ -18,6 +18,7 @@
 
 #include <fmt/core.h>
 #include <folly/Random.h>
+#include <folly/ScopeGuard.h>
 
 #include <chrono>
 
@@ -224,6 +225,8 @@ void BigHash::getCounters(const CounterVisitor& visitor) const {
   bucketExpirationsDist_x100_.visitQuantileEstimator(
       visitor, "navy_bh_expired_loop_x100");
   bhLifetimeSecs_.visitQuantileEstimator(visitor, "navy_bh_item_lifetime_secs");
+  lookupLatency_.visitQuantileEstimator(visitor, "navy_bh_lookup_latency_us");
+  insertLatency_.visitQuantileEstimator(visitor, "navy_bh_insert_latency_us");
 }
 
 void BigHash::persist(RecordWriter& rw) {
@@ -297,6 +300,10 @@ Status BigHash::insert(HashedKey hk,
                        uint8_t /* poolId */,
                        uint32_t /* expiryTime */,
                        uint32_t /* lastAccessTimeSecs */) {
+  auto start = getSteadyClock();
+  SCOPE_EXIT {
+    insertLatency_.trackValue(toMicros(getSteadyClock() - start).count());
+  };
   const auto bid = getBucketId(hk);
   insertCount_.inc();
 
@@ -397,6 +404,10 @@ uint64_t BigHash::estimateWriteSize(HashedKey, BufferView) const {
 Status BigHash::lookup(HashedKey hk,
                        Buffer& value,
                        uint32_t& lastAccessTimeSecs) {
+  auto start = getSteadyClock();
+  SCOPE_EXIT {
+    lookupLatency_.trackValue(toMicros(getSteadyClock() - start).count());
+  };
   lastAccessTimeSecs = 0;
   const auto bid = getBucketId(hk);
   lookupCount_.inc();

cachelib/navy/bighash/BigHash.h

@@ -271,6 +271,8 @@ class BigHash final : public Engine, folly::NonCopyableNonMovable {
   // PercentileStats generates outputs in integers, so amplify by 100x
   mutable util::PercentileStats bucketExpirationsDist_x100_;
   mutable util::PercentileStats bhLifetimeSecs_;
+  mutable util::PercentileStats lookupLatency_;
+  mutable util::PercentileStats insertLatency_;
 
   friend class ValidBucketChecker;
 };

cachelib/navy/bighash/tests/BigHashTest.cpp

@@ -184,6 +184,28 @@ TEST(BigHash, SimpleStats) {
   }
 }
 
+TEST(BigHash, LatencyStats) {
+  BigHash::Config config;
+  setLayout(config, 64, 1);
+  auto device = std::make_unique<NiceMock<MockDevice>>(config.cacheSize, 64);
+  config.device = device.get();
+
+  BigHash bh(std::move(config));
+
+  Buffer value;
+  uint32_t lat = 0;
+  EXPECT_EQ(Status::Ok,
+            bh.insert(makeHK("key"), makeView("12345"), 0 /* poolId */,
+                      0 /* expiryTime */));
+  EXPECT_EQ(Status::Ok, bh.lookup(makeHK("key"), value, lat));
+
+  MockCounterVisitor helper;
+  EXPECT_CALL(helper, call(_, _)).Times(AtLeast(0));
+  EXPECT_CALL(helper, call(strPiece("navy_bh_lookup_latency_us_p99"), _));
+  EXPECT_CALL(helper, call(strPiece("navy_bh_insert_latency_us_p99"), _));
+  bh.getCounters({toCallback(helper)});
+}
+
 TEST(BigHash, EvictionStats) {
   BigHash::Config config;
   setLayout(config, 64, 1);