Richard/packaging

Summary:
Fixes #ISSUE_NUMBER

X-link: https://github.com/facebookincubator/rebalancer/pull/40

Reviewed By: sravi-in

Differential Revision: D107910573

Pulled By: r-barnes

fbshipit-source-id: 5e5f2c3c42ec68b75d3309a2a276e35504cd5e48

Author: r-barnes

build/fbcode_builder/manifests/fbthrift

@@ -23,6 +23,9 @@ enable_tests=ON
 [cmake.defines.any(os=windows,test=off)]
 enable_tests=OFF
 
+[cmake.defines.all(os=linux,feature_shared_libs=on)]
+BUILD_SHARED_LIBS=ON
+
 # Features. The defaults match the historical full build. Consumers that
 # only need codegen + (de)serialization pull this dep as
 # `fbthrift = !rpc, !benchmark` to skip both the RPC link-graph and the
@@ -31,6 +34,7 @@ enable_tests=OFF
 default = rpc, benchmark
 rpc =
 benchmark =
+shared_libs =
 
 [cmake.defines.feature_rpc=off]
 THRIFT_RPC=OFF

build/fbcode_builder/manifests/fmt

@@ -9,10 +9,17 @@ sha256 = ea7de4299689e12b6dddd392f9896f08fb0777ac7168897a244a6d6085043fea
 builder = cmake
 subdir = fmt-12.1.0
 
+[features]
+default =
+shared_libs =
+
 [cmake.defines]
 FMT_TEST = OFF
 FMT_DOC = OFF
 
+[cmake.defines.feature_shared_libs=on]
+BUILD_SHARED_LIBS = ON
+
 [homebrew]
 fmt
 

build/fbcode_builder/manifests/folly

@@ -35,6 +35,13 @@ zlib
 libaio
 libiberty
 libunwind
+# folly uses OpenSSL on every platform (SSL contexts, hashing, etc.).
+# On Linux, openssl's manifest uses builder=nop and resolves via the
+# distro's openssl-devel package, so listing it here only causes
+# install-system-deps --recursive to pick that package up. Without
+# this, downstream consumers that don't otherwise pull in fizz/wangle/
+# fbthrift have to discover this transitive system dep themselves.
+openssl
 
 # xz depends on autoconf which does not build on
 # Windows
@@ -49,9 +56,16 @@ fbcode/folly = folly
 ^fbcode/folly/folly-config\.h$
 ^fbcode/folly/public_tld/build/facebook_.*
 
+[features]
+default =
+shared_libs =
+
 [cmake.defines]
 BUILD_SHARED_LIBS=OFF
 
+[cmake.defines.feature_shared_libs=on]
+BUILD_SHARED_LIBS=ON
+
 [cmake.defines.not(os=windows)]
 BOOST_LINK_STATIC=ON
 

build/fbcode_builder/manifests/gflags

@@ -12,7 +12,6 @@ subdir = gflags-2.3.0
 [cmake.defines]
 BUILD_SHARED_LIBS = ON
 BUILD_STATIC_LIBS = ON
-#BUILD_gflags_nothreads_LIB = OFF
 BUILD_gflags_LIB = ON
 
 [homebrew]

build/fbcode_builder/manifests/glog

@@ -13,6 +13,12 @@ rev = 3411d58669fe07e70335b252299432a00d1e7c6c
 
 [build]
 builder = cmake
+# The patchfile removes glog's unconditional CMAKE_CXX_VISIBILITY_PRESET=hidden
+# (cmake_minimum_required(VERSION 3.16) forces CMP0063=NEW, making
+# CMAKE_POLICY_DEFAULT_CMP0063=OLD ineffective). Applied unconditionally;
+# default-visibility symbols in a static archive are harmless for consumers
+# that don't need the shared_libs feature.
+patchfile = glog_default_visibility.patch
 
 [dependencies]
 gflags
@@ -35,4 +41,3 @@ libgoogle-glog-dev
 
 [rpms.distro=fedora]
 glog-devel
-

build/fbcode_builder/manifests/rebalancer

@@ -17,16 +17,26 @@ builder = cmake
 [cmake.defines]
 CMAKE_POSITION_INDEPENDENT_CODE=ON
 
+# Build the example/demo executables only when getdeps is invoked with
+# tests enabled (test=on -- the default for `getdeps build` without
+# --no-tests). Wheel builds pass --no-tests so the wheel stays
+# data-only. CI test jobs get the examples built and link-checked
+# automatically without needing to thread EXAMPLES=ON through every
+# workflow's --extra-cmake-defines.
+[cmake.defines.test=on]
+EXAMPLES=ON
+
 [dependencies]
 boost
 # Rebalancer only uses fbthrift's codegen + (de)serialization. Skip the RPC
 # transport stack (fizz/wangle/mvfst, none of which it links) and the
-# benchmark executables.
-fbthrift = !rpc, !benchmark
-fmt
-folly
-gflags
-glog
+# benchmark executables. shared_libs builds folly/fbthrift/fmt/gflags/glog as
+# shared libraries, which avoids duplicate static-initializer crashes and lets
+# the wheel bundler (auditwheel/delocate) reason about each dep as a single
+# shared object.
+fbthrift = !rpc, !benchmark, shared_libs
+fmt = shared_libs
+folly = shared_libs
 googletest
 highs-optimizer
 xxhash

build/fbcode_builder/patches/glog_default_visibility.patch

@@ -0,0 +1,11 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -61,7 +61,4 @@ endif (NOT WITH_THREADS)
+
+-set (CMAKE_C_VISIBILITY_PRESET hidden)
+-set (CMAKE_CXX_VISIBILITY_PRESET hidden)
+ set (CMAKE_POSITION_INDEPENDENT_CODE ON)
+-set (CMAKE_VISIBILITY_INLINES_HIDDEN ON)
+
+ set (CMAKE_DEBUG_POSTFIX d)