Skip to content

Commit dada14c

Browse files
Shitanshu Shahmeta-codesync[bot]
authored andcommitted
Disable range-v3 internal tests on GCC 13
Summary: range-v3 0.11.0 builds its own test suite with `-Werror` by default. GCC 13 (Ubuntu 24.04) emits a new `-Wchanges-meaning` diagnostic in `include/meta/meta.hpp:3190` — the `partition_<Fn>::invoke` member alias shadows the namespace-level `meta::invoke` — that GCC 11 did not flag, so the range-v3 dependency build fails with thousands of identical errors before any consuming project even starts compiling. Fix: set `RANGE_V3_TESTS=OFF` in the shared range-v3 getdeps manifest, mirroring the existing `RANGE_V3_EXAMPLES=OFF`. No getdeps consumer needs range-v3's internal test suite — only its installed headers — so disabling it globally is the correct fix rather than a per-project workaround. History — why this keeps coming back, and why the fix belongs in the manifest: - D106906602 (2026-05-30): openr first worked this around by appending `--extra-cmake-defines '{"RANGE_V3_TESTS":"OFF"}'` to the "Build openr" step in the generated CI workflow `fbcode/openr/public_tld/.github/workflows/getdeps_linux.yml`. That fixed CI and stayed in effect through early June (still present as of D107302581, 2026-06-02). - D108750058 (2026-06-16, "Upgrade getdeps template's sccache-action v0.0.9 -> v0.0.10"): a routine cross-project regeneration of every OSS `getdeps_linux.yml` from the shared fbcode_builder template. The generator has no manifest hook to carry a per-project `--extra-cmake-defines`, so it silently dropped openr's manual edit, reintroducing the GCC 13 failure. - 2026-06-23: the openr OSS GitHub build fails again on range-v3, identical to before. The generated workflow is the wrong layer: it is overwritten on every template regeneration, and the template itself is shared by all OSS projects so it cannot carry an openr/range-specific flag. The manifest is the durable source of truth — `getdeps build` re-derives each dependency's `[cmake.defines]` from its own manifest at build time, independent of any workflow regeneration — so the fix placed here cannot be clobbered. Reviewed By: mloo3 Differential Revision: D109720165 fbshipit-source-id: 16326ea06b8b592f121a480465f84aae7ccbb4f8
1 parent d557ce7 commit dada14c

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

build/fbcode_builder/manifests/range-v3

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@ subdir = range-v3-0.11.0
1212

1313
[cmake.defines]
1414
RANGE_V3_EXAMPLES=OFF
15+
RANGE_V3_TESTS=OFF

0 commit comments

Comments
 (0)